-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add | Out-String -Width 120 to tests with Format-Table command. #6761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… could work also without console dimensions specified.
|
I don't like the temporary solution. If |
|
I agree with @iSazonov |
|
The solution is only temporary so that to not be blocked when migrating the builds on different service (currently the tests for Format-Table are failing on vsts). The issue with Format-Table would still remain open and would be fixed later. |
|
MSFT could skip this tests on VSTS but not on GitHub. |
|
Do we want to just skip the tests for the environment where they are not working for now? |
|
Can we root cause why it's failing in VSTS? Perhaps in VSTS there is a console, but the width is zero? @kalgiz can you just run |
|
@kalgiz Please resolve merge conflicts |
|
@SteveL-MSFT I checked the console width in vsts and it is equal to 0. That is why the output from Format-Table is null. |
|
It is better fix this in code - there may be other similar environments. |
|
I prepared a PR #6883 to fix the issue, so I am closing this one. |
PR Summary
Add | Out-String -Width 120 to tests with Format-Table command. The tests are not passing on vsts due a bug in Format-Table command (probably unspecified dimensions of the console).
The temporary solution for issue: #6748
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests