Skip to content

Conversation

@kalgiz
Copy link
Contributor

@kalgiz kalgiz commented Apr 27, 2018

PR Summary

Add | Out-String -Width 120 to tests with Format-Table command. The tests are not passing on vsts due a bug in Format-Table command (probably unspecified dimensions of the console).
The temporary solution for issue: #6748

PR Checklist

@iSazonov
Copy link
Collaborator

I don't like the temporary solution. If Format-Table has a bug we should fix it.

@SteveL-MSFT
Copy link
Member

I agree with @iSazonov

@kalgiz
Copy link
Contributor Author

kalgiz commented Apr 30, 2018

The solution is only temporary so that to not be blocked when migrating the builds on different service (currently the tests for Format-Table are failing on vsts). The issue with Format-Table would still remain open and would be fixed later.

@iSazonov
Copy link
Collaborator

iSazonov commented Apr 30, 2018

MSFT could skip this tests on VSTS but not on GitHub.

@kalgiz
Copy link
Contributor Author

kalgiz commented May 2, 2018

Do we want to just skip the tests for the environment where they are not working for now?

@SteveL-MSFT
Copy link
Member

Can we root cause why it's failing in VSTS? Perhaps in VSTS there is a console, but the width is zero? @kalgiz can you just run pwsh -c [console]::WindowWidth in VSTS and see what it returns?

@adityapatwardhan
Copy link
Member

@kalgiz Please resolve merge conflicts

@kalgiz
Copy link
Contributor Author

kalgiz commented May 15, 2018

@SteveL-MSFT I checked the console width in vsts and it is equal to 0. That is why the output from Format-Table is null.

@iSazonov
Copy link
Collaborator

It is better fix this in code - there may be other similar environments.
I believe it is here

@kalgiz
Copy link
Contributor Author

kalgiz commented May 16, 2018

I prepared a PR #6883 to fix the issue, so I am closing this one.

@kalgiz kalgiz closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants