-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Use new -WorkingDirectory parameter on pwsh.exe to be able to use context menu when path contains single quotes. #6660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new -WorkingDirectory parameter on pwsh.exe to be able to use context menu when path contains single quotes. #6660
Conversation
…text menu when path contains single quotes. This is pending on PR 6612
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Put |
…o explorer_contextMenu_FixSingleQuotes
|
I pulled in the required changes from master (that are merged now) and tested locally that it works using a folder that ends with a single quote. There was one sporadic test failure (it passed in my branch, which is now even with |
|
#6707 is opened to track the test failure in AppVeyor. I have restarted the build. |
|
Thanks |
|
Can cross-reference this with https://superuser.com/questions/1323501/bug-in-powershell-classes-when-script-is-in-a-folder-containing-a-single-quote - is this the same issue here? My problem is with the class statement inside a script that resides in a folder containing a single quote character. |
|
@munrobasher No, this issue/PR was about a different problem although it looks similar. |

PR Summary
Fixes #6598 by using PR #6612 that adds a
-WorkingDirectoryparameter onpwsh.exethat this PR uses in order to make the explorer context menu also work when the path contains a single quote.Technical note:
"is an escape character for a double quote in WiX.Note that this bug also occurs for the Windows PowerShell Explorer integration in Windows 10.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests