Skip to content

make gem use sudo for macOS #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 3 commits into from
Apr 10, 2018
Merged

make gem use sudo for macOS #6610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfa89d9
run gem install with sudo on macos
TravisEz13 Apr 9, 2018
bf8b281
remove special casing gem install on macos during official build
TravisEz13 Apr 9, 2018
205244b
Minor style fix
daxian-dbw Apr 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions build.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1671,9 +1671,14 @@ function Start-PSBootstrap {
# Install [fpm](https://github.com/jordansissel/fpm) and [ronn](https://github.com/rtomayko/ronn)
if ($Package) {
try {
# We cannot guess if the user wants to run gem install as root
Start-NativeExecution { gem install fpm -v 1.9.3 }
Start-NativeExecution { gem install ronn -v 0.7.3 }
# We cannot guess if the user wants to run gem install as root on linux and windows,
# but macOs usually requires sudo
$gemsudo = ''
if($Environment.IsMacOS) {
$gemsudo = $sudo
}
Start-NativeExecution ([ScriptBlock]::Create("$gemsudo gem install fpm -v 1.9.3"))
Start-NativeExecution ([ScriptBlock]::Create("$gemsudo gem install ronn -v 0.7.3"))
} catch {
Write-Warning "Installation of fpm and ronn gems failed! Must resolve manually."
}
Expand Down
7 changes: 0 additions & 7 deletions tools/releaseBuild/macOS/PowerShellPackageVsts.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,6 @@ try {

if ($BootStrap.IsPresent) {
Start-PSBootstrap -Package

# The gem install is run by bootstrap without sudo and fails on macOS.
# Run the commands with sudo, to resolve the issue
Write-Verbose -Message "Installing fpm..." -Verbose
Start-NativeExecution { sudo gem install fpm -v 1.8.1 }
Write-Verbose -Message "Installing ronn..." -Verbose
Start-NativeExecution { sudo gem install ronn }
}

if ($Build.IsPresent) {
Expand Down