Remove extraneous SSH and install docs from PowerShell/PowerShell #6517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyaiello
requested review from
TravisEz13
and removed request for
HemantMahawar
SteveL-MSFT
approved these changes
Mar 28, 2018
Member
|
@joeyaiello you need to add some words back to .spelling |
Collaborator
|
Maybe add this doc links to main README? |
Contributor
|
This is a breaking change in the sense that existing links in code comments or blogs get broken. Is it possible/worthwhile to have at least a redirect to the new place instead of removing the doc completely? Maybe not forever but for half a year as a transition period? |
Contributor
Author
|
@bergmeister I'd really not rather keep stubs around when these docs are particularly easy to Google....If you want to point at a specific tree commit, you can do that. (I get why that's not desirable when you want up-to-date docs, but it does work...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR removes the
SSHRemotingandinstallfolders withindemos. I also removedSSHRemotingfrom an existing test, as well as the.spellingregion for it.These docs are now hosted on docs.microsoft.com:
We may also want to delete
docs/installationfrom PS/PS, but it's unclear to me yet if folks know to update the doc in PowerShell-Docs from here on out (and it may contain some installation info about installing a preview build that hasn't yet been merged into PowerShell-Docs). /cc @TravisEz13If I should delete that, I'll do it in a follow-up PR. Or if someone wants to push into my fork, that's cool too, I just didn't want to do it without a Maintainer giving input first.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests