Simplify the paths the MSI uses #6442
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. | ||
|
|
||
| function Test-Elevated { | ||
| [CmdletBinding()] | ||
| [OutputType([bool])] | ||
| Param() | ||
|
|
||
| # if the current Powershell session was called with administrator privileges, | ||
| # the Administrator Group's well-known SID will show up in the Groups for the current identity. | ||
| # Note that the SID won't show up unless the process is elevated. | ||
| return (([Security.Principal.WindowsIdentity]::GetCurrent()).Groups -contains "S-1-5-32-544") | ||
| } | ||
|
|
||
| function Invoke-Msiexec { | ||
| param( | ||
| [Parameter(ParameterSetName = 'Install', Mandatory)] | ||
| [Switch]$Install, | ||
|
|
||
| [Parameter(ParameterSetName = 'Uninstall', Mandatory)] | ||
| [Switch]$Uninstall, | ||
|
|
||
| [Parameter(Mandatory)] | ||
| [ValidateScript({Test-Path -Path $_})] | ||
| [String]$MsiPath, | ||
|
|
||
| [Parameter(ParameterSetName = 'Install')] | ||
| [HashTable] $Properties | ||
|
|
||
| ) | ||
| $action = "$($PsCmdlet.ParameterSetName)ing" | ||
| if ($Install.IsPresent) { | ||
| $switch = '/I' | ||
| } else { | ||
| $switch = '/x' | ||
| } | ||
|
|
||
| $additionalOptions = @() | ||
| if ($Properties) { | ||
| foreach ($key in $Properties.Keys) { | ||
| $additionalOptions += "$key=$($Properties.$key)" | ||
| } | ||
| } | ||
|
|
||
| $argumentList = "$switch $MsiPath /quiet /l*vx $msiLog $additionalOptions" | ||
| $msiExecProcess = Start-Process msiexec.exe -Wait -ArgumentList $argumentList -NoNewWindow -PassThru | ||
| if ($msiExecProcess.ExitCode -ne 0) { | ||
| $exitCode = $msiExecProcess.ExitCode | ||
| throw "$action MSI failed and returned error code $exitCode." | ||
| } | ||
| } | ||
|
|
||
| Describe -Name "Windows MSI" -Fixture { | ||
| BeforeAll { | ||
| $msiX64Path = $env:PsMsiX64Path | ||
|
|
||
| # Get any existing powershell core in the path | ||
| $beforePath = @(([System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE')) -split ';' | | ||
| Where-Object {$_ -like '*files\powershell*'}) | ||
|
|
||
| $msiLog = Join-Path -Path $TestDrive -ChildPath 'msilog.txt' | ||
|
|
||
| foreach ($pathPart in $beforePath) { | ||
| Write-Warning "Found existing PowerShell path: $pathPart" | ||
| } | ||
|
|
||
| if (!(Test-Elevated)) { | ||
|
||
| Write-Warning "Tests must be elevated" | ||
| } | ||
| $uploadedLog = $false | ||
| } | ||
| BeforeEach { | ||
| $Error.Clear() | ||
| } | ||
| AfterEach { | ||
| if ($Error.Count -ne 0 -and !$uploadedLog) { | ||
| if ($env:APPVEYOR) { | ||
| Push-AppveyorArtifact $msiLog | ||
| } else { | ||
| Copy-Item -Path $msiLog -Destination $env:temp -Force | ||
| Write-Verbose "MSI log is at $env:temp\msilog.txt" -Verbose | ||
| } | ||
| $uploadedLog = $true | ||
| } | ||
| } | ||
|
|
||
| Context "Add Path disabled" { | ||
| It "MSI should install without error" -Skip:(!(Test-Elevated)) { | ||
| { | ||
| Invoke-MsiExec -Install -MsiPath $msiX64Path -Properties @{ADD_PATH = 0} | ||
| } | Should -Not -Throw | ||
| } | ||
|
|
||
| It "MSI should have not be updated path" -Skip:(!(Test-Elevated)) { | ||
| $psPath = ([System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE')) -split ';' | | ||
| Where-Object {$_ -like '*files\powershell*' -and $_ -notin $beforePath} | ||
|
|
||
| $psPath | Should -BeNullOrEmpty | ||
| } | ||
|
|
||
| It "MSI should uninstall without error" -Skip:(!(Test-Elevated)) { | ||
| { | ||
| Invoke-MsiExec -Uninstall -MsiPath $msiX64Path | ||
| } | Should -Not -Throw | ||
| } | ||
| } | ||
|
|
||
| Context "Add Path enabled" { | ||
| It "MSI should install without error" -Skip:(!(Test-Elevated)) { | ||
| { | ||
| Invoke-MsiExec -Install -MsiPath $msiX64Path -Properties @{ADD_PATH = 1} | ||
| } | Should -Not -Throw | ||
| } | ||
|
|
||
| It "MSI should have updated path" -Skip:(!(Test-Elevated)) { | ||
| $psPath = ([System.Environment]::GetEnvironmentVariable('PATH', 'MACHINE')) -split ';' | | ||
| Where-Object {$_ -like '*files\powershell*' -and $_ -notin $beforePath} | ||
|
|
||
| $psPath | Should -Not -BeNullOrEmpty | ||
| } | ||
|
|
||
| It "MSI should uninstall without error" -Skip:(!(Test-Elevated)) { | ||
| { | ||
| Invoke-MsiExec -Uninstall -MsiPath $msiX64Path | ||
| } | Should -Not -Throw | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a
Test-Pathin validate scriptThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed