Skip to content

Fix the NullRefException when using '-PipelineVariable' with 'DynamicParam' block #6433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 1 commit into from
Mar 20, 2018
Merged

Fix the NullRefException when using '-PipelineVariable' with 'DynamicParam' block #6433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/System.Management.Automation/engine/MshCommandRuntime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3698,7 +3698,9 @@ internal void RemoveVariableListsInPipe()
if (this.PipelineVariable != null)
{
this.OutputPipe.RemovePipelineVariable();
_state.PSVariable.Remove(this.PipelineVariable);
// '_state' could be null when a 'DynamicParam' block runs because the 'DynamicParam' block runs in 'DoPrepare',
// before 'PipelineProcessor.SetupParameterVariables' is called, where '_state' is initialized.
_state?.PSVariable.Remove(this.PipelineVariable);
}
}
}
Expand Down
11 changes: 11 additions & 0 deletions test/powershell/engine/ParameterBinding/ParameterBinding.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,17 @@ Describe "Parameter Binding Tests" -Tags "CI" {
}
}

It "PipelineVariable shouldn't cause a NullRef exception when 'DynamicParam' block is present" {
function DynamicParamTest {
[CmdletBinding()]
param()
dynamicparam { }
process { 'hi' }
}

DynamicParamTest -PipelineVariable bar | ForEach-Object { $bar } | Should -Be "hi"
}

Context "Use automatic variables as default value for parameters" {
BeforeAll {
## Explicit use of 'CmdletBinding' make it a script cmdlet
Expand Down