Skip to content

Conversation

@sdwheeler
Copy link
Collaborator

The Install docs for version 6 have been move to the Docs repo. Removed the installation folder from this repo and updated README.md to point to new published location.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of the links (like Ubuntu) currently return 404, when will the install docs be updated and published so the links work correctly?

@sdwheeler
Copy link
Collaborator Author

@SteveL-MSFT I had a typo in the links. Fixed that. Should be good now.

README.md Outdated
[in-fedora26]: https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-macos-and-linux#fedora-26
[in-archlinux]: https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-macos-and-linux#arch-linux
[in-appimage]: https://docs.microsoft.com/en-us/powershell/scripting/setup/installing-powershell-core-on-macos-and-linux#linux-appimage
[in-macos]: https://github.com/PowerShell/PowerShell/tree/master/docs/installation/macos.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mac link wasn't updated

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix mac link

@sdwheeler
Copy link
Collaborator Author

@TravisEz13 Sorry about that. Fixed in latest commit.

@TravisEz13
Copy link
Member

I filed MicrosoftDocs/PowerShell-Docs#2166 . We should have this implemented soon after we make the switch.

@TravisEz13
Copy link
Member

TravisEz13 commented Mar 8, 2018

Need to verify that these changes have been made to the docs:

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quickly (there may be other differences if looking closely) compared the setup docs at powershell-docs with the ones here, and it seems they are not in sync:

  1. The docs about Linux and Mac has been split into different markdown files since Jan 9, but in powershell-docs they are still in the same file.
  2. The powershell core version used in those files in this repository is 6.0.1, but in powershell-docs, it's 6.0.0.
  3. The content about macOS is not in sync with the mac doc in this repo.

I think we need to make sure the docs in PowerShell-Docs are in sync with the ones in this repository before removing those from this repo.

@stale
Copy link

stale bot commented Apr 7, 2018

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

@stale stale bot added the Stale label Apr 7, 2018
@stale
Copy link

stale bot commented Apr 17, 2018

This PR has be automatically close because it is stale. If you wish to continue working on the PR, please first update the PR, then reopen it.
Thanks again for your contribution.
Community members are welcome to grab these works.

@stale stale bot closed this Apr 17, 2018
@sdwheeler sdwheeler deleted the sdw-readme branch April 25, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants