Skip to content

Added Service Point Manager call to force Tls12. #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 6 commits into from
Mar 9, 2018
Merged

Added Service Point Manager call to force Tls12. #6310

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
28e7d50
Added Service Point Manager call to force Tls12.
DarqueWarrior Mar 4, 2018
0bcf256
Addressed code review to have change match #6236
DarqueWarrior Mar 8, 2018
412dbc5
Added code to restore original value.
DarqueWarrior Mar 8, 2018
fe967dd
Try Finally put in place per code review.
DarqueWarrior Mar 8, 2018
67c8573
Moving code to outer try and finally blocks.
DarqueWarrior Mar 9, 2018
65880ea
Remove the unneeded empty lines
daxian-dbw Mar 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/install-powershell.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ $architecture = if (-not $IsWinEnv) {
$tempDir = Join-Path ([System.IO.Path]::GetTempPath()) ([System.IO.Path]::GetRandomFileName())
New-Item -ItemType Directory -Path $tempDir -Force > $null
try {
# Setting Tls to 12 to prevent the Invoke-WebRequest : The request was
# aborted: Could not create SSL/TLS secure channel. error.
$originalValue = [Net.ServicePointManager]::SecurityProtocol
[Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12

if ($Daily) {
if (-not (Get-Module -Name PackageManagement -ListAvailable)) {
throw "PackageManagement module is required to install daily PowerShell Core."
Expand Down Expand Up @@ -227,5 +232,8 @@ try {
Write-Host "Please restart pwsh" -ForegroundColor Magenta
}
} finally {
# Restore original value
[Net.ServicePointManager]::SecurityProtocol = $originalValue

Remove-Item -Path $tempDir -Recurse -Force -ErrorAction SilentlyContinue
}