Skip to content

Upgrade Pester tests in Microsoft.PowerShell.Security folder to dashed v4 syntax #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 10 commits into from
Mar 23, 2018
Merged

Upgrade Pester tests in Microsoft.PowerShell.Security folder to dashed v4 syntax #6256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e7141b9
6245 use updated Pester parameter syntax
KevinMarquette Feb 27, 2018
1a5b5e1
remove should throw
KevinMarquette Feb 27, 2018
e485a86
use -BeFalse and -BeTrue parameters
KevinMarquette Feb 27, 2018
e09c3c5
Set invalid test to pending
KevinMarquette Feb 27, 2018
60cdb81
Changed the testcases to a valid set of locations
KevinMarquette Feb 27, 2018
f08815b
revert change of is null test that changed functionality
KevinMarquette Feb 27, 2018
8fe1c25
revert removal of should not throw
KevinMarquette Feb 27, 2018
fd146d1
corrected whitespace change
KevinMarquette Feb 27, 2018
e3b32c0
typo corrections
KevinMarquette Feb 28, 2018
7e67465
resolve issues with scriptblocks
KevinMarquette Mar 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/powershell/Modules/Microsoft.PowerShell.Security/AclCmdlets.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
Describe "Acl cmdlets are available and operate properly" -Tag CI {
It "Get-Acl returns an ACL object" -pending:(!$IsWindows) {
$ACL = get-acl $TESTDRIVE
$ACL | Should BeOfType "System.Security.AccessControl.DirectorySecurity"
$ACL | Should -BeOfType "System.Security.AccessControl.DirectorySecurity"
}
It "Set-Acl can set the ACL of a directory" -pending {
Setup -d testdir
$directory = "$TESTDRIVE/testdir"
$acl = get-acl $directory
$accessRule = [System.Security.AccessControl.FileSystemAccessRule]::New("Everyone","FullControl","ContainerInherit,ObjectInherit","None","Allow")
$acl.AddAccessRule($accessRule)
{ $acl | Set-Acl $directory } | should not throw
{ $acl | Set-Acl $directory } | Should -Not -Throw

$newacl = get-acl $directory
$newrule = $newacl.Access | Where-Object { $accessrule.FileSystemRights -eq $_.FileSystemRights -and $accessrule.AccessControlType -eq $_.AccessControlType -and $accessrule.IdentityReference -eq $_.IdentityReference }
$newrule |Should not benullorempty
$newrule | Should -Not -BeNullOrEmpty
}
}
32 changes: 16 additions & 16 deletions test/powershell/Modules/Microsoft.PowerShell.Security/CertificateProvider.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ Describe "Certificate Provider tests" -Tags "CI" {
$result | should not be null
$result | ForEach-Object {
$resolvedPath = Resolve-Path $_.PSPath
$resolvedPath.Provider | should be $expectedResolvedPath.Provider
$resolvedPath.ProviderPath.TrimStart('\') | should be $expectedResolvedPath.ProviderPath.TrimStart('\')
$resolvedPath.Provider | Should -Be $expectedResolvedPath.Provider
$resolvedPath.ProviderPath.TrimStart('\') | Should -Be $expectedResolvedPath.ProviderPath.TrimStart('\')
}
}
it "Should return two items at the root of the provider" {
(Get-Item -Path cert:\*).Count | should be 2
(Get-Item -Path cert:\*).Count | Should -Be 2
}
it "Should be able to get multiple items explictly" {
(get-item cert:\LocalMachine , cert:\CurrentUser).Count | should be 2
(get-item cert:\LocalMachine , cert:\CurrentUser).Count | Should -Be 2
}
it "Should return PathNotFound when getting a non-existant certificate store" {
{Get-Item cert:\IDONTEXIST -ErrorAction Stop} | ShouldBeErrorId "PathNotFound,Microsoft.PowerShell.Commands.GetItemCommand"
Expand All @@ -70,10 +70,10 @@ Describe "Certificate Provider tests" -Tags "CI" {
}
Context "Get-ChildItem tests"{
it "should be able to get a container using a wildcard" {
(Get-ChildItem Cert:\CurrentUser\M?).PSPath | should be 'Microsoft.PowerShell.Security\Certificate::CurrentUser\My'
(Get-ChildItem Cert:\CurrentUser\M?).PSPath | Should -Be 'Microsoft.PowerShell.Security\Certificate::CurrentUser\My'
}
it "Should return two items at the root of the provider" {
(Get-ChildItem -Path cert:\).Count | should be 2
(Get-ChildItem -Path cert:\).Count | Should -Be 2
}
}
}
Expand Down Expand Up @@ -112,7 +112,7 @@ Describe "Certificate Provider tests" -Tags "Feature" {
$leafPath = Join-Path -Path $path -ChildPath $expectedThumbprint
$cert = (Get-item -LiteralPath $leafPath)
$cert | should not be null
$cert.Thumbprint | should be $expectedThumbprint
$cert.Thumbprint | Should -Be $expectedThumbprint
}
it "Should be able to get DnsNameList of certifate by path: <path>" -TestCases $currentUserMyLocations {
param([string] $path)
Expand All @@ -123,9 +123,9 @@ Describe "Certificate Provider tests" -Tags "Feature" {
$cert = (Get-item -LiteralPath $leafPath)
$cert | should not be null
$cert.DnsNameList | should not be null
$cert.DnsNameList.Count | should be 1
$cert.DnsNameList[0].Unicode | should be $expectedName
$cert.DnsNameList[0].Punycode | should be $expectedEncodedName
$cert.DnsNameList.Count | Should -Be 1
$cert.DnsNameList[0].Unicode | Should -Be $expectedName
$cert.DnsNameList[0].Punycode | Should -Be $expectedEncodedName
}
it "Should be able to get DNSNameList of certifate by path: <path>" -TestCases $currentUserMyLocations {
param([string] $path)
Expand All @@ -135,17 +135,17 @@ Describe "Certificate Provider tests" -Tags "Feature" {
$cert = (Get-item -LiteralPath $leafPath)
$cert | should not be null
$cert.EnhancedKeyUsageList | should not be null
$cert.EnhancedKeyUsageList.Count | should be 1
$cert.EnhancedKeyUsageList[0].ObjectId.Length | should not be 0
$cert.EnhancedKeyUsageList[0].ObjectId | should be $expectedOid
$cert.EnhancedKeyUsageList.Count | Should -Be 1
$cert.EnhancedKeyUsageList[0].ObjectId.Length | Should -Not -Be 0
$cert.EnhancedKeyUsageList[0].ObjectId | Should -Be $expectedOid
}
it "Should filter to codesign certificates" {
$allCerts = get-item cert:\CurrentUser\My\*
$codeSignCerts = get-item cert:\CurrentUser\My\* -CodeSigningCert
$codeSignCerts | should not be null
$allCerts | should not be null
$nonCodeSignCertCount = $allCerts.Count - $codeSignCerts.Count
$nonCodeSignCertCount | should not be 0
$nonCodeSignCertCount | Should -Not -Be 0
}
it "Should be able to exclude by thumbprint" {
$allCerts = get-item cert:\CurrentUser\My\*
Expand All @@ -154,7 +154,7 @@ Describe "Certificate Provider tests" -Tags "Feature" {
$allCerts | should not be null
$allCertsExceptOne | should not be null
$countDifference = $allCerts.Count - $allCertsExceptOne.Count
$countDifference | should be 1
$countDifference | Should -Be 1
}
}
Context "Get-ChildItem tests"{
Expand All @@ -164,7 +164,7 @@ Describe "Certificate Provider tests" -Tags "Feature" {
$codeSignCerts | should not be null
$allCerts | should not be null
$nonCodeSignCertCount = $allCerts.Count - $codeSignCerts.Count
$nonCodeSignCertCount | should not be 0
$nonCodeSignCertCount | Should -Not -Be 0
}
}
}
Loading