Skip to content

Fix date tests failing in travis CI full builds #6249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Feb 26, 2018
Merged

Fix date tests failing in travis CI full builds #6249

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2829b95
[Feature] Fix date tests failing in travis CI full builds
TravisEz13 Feb 26, 2018
d0dc49b
[Feature] Address PR feedback
TravisEz13 Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tools/travis.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,6 @@ elseif($Stage -eq 'Build')

if ($isFullBuild) {
$pesterParam['Tag'] = @('CI','Feature','Scenario')
Copy link
Member

@adityapatwardhan adityapatwardhan Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a ExcludeTag for RequireSudoOnUnix

Copy link
Member

@daxian-dbw daxian-dbw Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RequireSudoOnUnix has already been added above.

     $pesterParam = @{
         'binDir'     = $output
         'PassThru'   = $true
         'Terse'      = $true
         'Tag'        = @()
         'ExcludeTag' = @('RequireSudoOnUnix')
         'OutputFile' = $testResultsNoSudo
     }

Copy link
Member Author

@TravisEz13 TravisEz13 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line 211

Copy link
Member

@adityapatwardhan adityapatwardhan Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed

$pesterParam['ExcludeTag'] = @()
} else {
$pesterParam['Tag'] = @('CI')
$pesterParam['ThrowOnFailure'] = $true
Expand Down