Revert SecurityProtocol to original value after calling github api #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vors
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
11 tasks
iSazonov
approved these changes
Feb 24, 2018
Contributor
|
Hmmm if we went this way, we would need to wrap all of the calls to github and not just this one. It's not clean, but we just have too many github calls for various build tools and actions. So we can safely treat enabling TLS 1.2 as a bootstrap requirement. |
markekraus
suggested changes
Feb 24, 2018
Contributor
markekraus
left a comment
markekraus
left a comment
There was a problem hiding this comment.
I'd rather accept my change see comment
Collaborator
Author
|
I see pros and cons in both approaches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow-up to rushedly merged #6235 to restore the original value of the
SecurityProtocol.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests