Skip to content

Enhance and refactor Add-Type cmdlet #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 53 commits into from
Apr 26, 2018
Merged

Enhance and refactor Add-Type cmdlet #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
cba4a9f
Enhance and refactor Add-Type cmdlet
iSazonov Nov 24, 2017
21b19dc
Revert ReferencedAssemblies to silently ignore null value
iSazonov Feb 9, 2018
5e10af1
Convert Namespace to property
iSazonov Feb 9, 2018
b21b8a9
Replace [ValidateNotNullOrEmpty()] with [ValidateNotNull()] in UsingN…
iSazonov Feb 10, 2018
0b360bd
Load assembly from MemoryStream
iSazonov Feb 13, 2018
3e128d0
Fix test patterns
iSazonov Feb 14, 2018
cb61dfd
Fix comments
iSazonov Feb 27, 2018
4eb4d99
Add TODO comment about cache size and unloading assemblies
iSazonov Feb 28, 2018
dafc4dd
Add parameter set name constants
iSazonov Feb 28, 2018
fcaf17a
Fix typo in comment
iSazonov Feb 28, 2018
fdab86b
Remove alias for ExtendedOptions
iSazonov Feb 28, 2018
74eb6b3
Use Utils.DefaultPowerShellAppBase for SDK home
iSazonov Feb 28, 2018
fdfac53
Replace s_generalDiagnosticOption with defaultDiagnosticOption
iSazonov Feb 28, 2018
ba983f8
Use this.SessionState.Path.CurrentLocation.Path as baseDirectory
iSazonov Feb 28, 2018
2a54e34
Use switch for ParameterSets
iSazonov Feb 28, 2018
e684147
Add comment about diagnostic message
iSazonov Mar 1, 2018
4a9e2d7
Fix typos and address some comments
iSazonov Mar 13, 2018
c303fba
Use IsWhiteSpace()
iSazonov Mar 14, 2018
9e84d60
Remove errorPosition line
iSazonov Mar 14, 2018
683c882
Rename ExtendedOptions to CompilerOptions
iSazonov Mar 14, 2018
70bf22f
Remove Diagnostics.Assert
iSazonov Mar 14, 2018
514611c
Fix parameters
iSazonov Mar 19, 2018
f23d100
Fix Files.wxs
iSazonov Mar 20, 2018
a3a9e90
Implement unify SourceCodeProcessing method
iSazonov Mar 21, 2018
676da67
Replace AsParallel() with foreach
iSazonov Mar 26, 2018
c6c0d38
Tests -> Pester 4
iSazonov Mar 26, 2018
006ea75
Some fixes
iSazonov Mar 30, 2018
dbfe396
Suppress unneeded output in test
iSazonov Mar 30, 2018
538f866
Fix usings
iSazonov Apr 2, 2018
30ff936
Fix PassThru
iSazonov Apr 3, 2018
6477c7a
Add [ValidateNotNullOrEmpty] in CompilerOptions
iSazonov Apr 3, 2018
bd7ca78
Use nameof
iSazonov Apr 3, 2018
840ae3f
Remove extra spaces
iSazonov Apr 3, 2018
ed95526
Fix case
iSazonov Apr 3, 2018
cbc9e48
Use var
iSazonov Apr 3, 2018
97b6b30
Remove extra lines
iSazonov Apr 3, 2018
f50d850
Remove code duplication
iSazonov Apr 3, 2018
a4b95a0
Move WriteVerbose() on better position
iSazonov Apr 3, 2018
125a46a
Remove PassThru check
iSazonov Apr 3, 2018
c2ed5f6
Use if
iSazonov Apr 3, 2018
7025470
Merge branch 'master' into addtype-enhance1
iSazonov Apr 3, 2018
5b3d4f9
Fix PassThru
iSazonov Apr 3, 2018
409bf82
Remove [Alias("IW")]
iSazonov Apr 4, 2018
3706d79
Use ParameterSetName == FromAssemblyNameParameterSetName
iSazonov Apr 4, 2018
9d3e3aa
Remove -Language from path parameter sets
iSazonov Apr 4, 2018
a1f3ec8
Remove ms.Flush()
iSazonov Apr 4, 2018
272628e
Fix return
iSazonov Apr 4, 2018
bf9a9a3
Rename DefaultArgsParse to ParseCompilerOption
iSazonov Apr 4, 2018
636e3c0
Rename ParseText to ParseSourceText
iSazonov Apr 4, 2018
d43507d
Fix PassThru
iSazonov Apr 4, 2018
44e64d3
Fix typo
iSazonov Apr 4, 2018
144eb08
Fix test
iSazonov Apr 4, 2018
ad6f79a
Fix typo in merge conflict resolve
iSazonov Apr 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions assets/files.wxs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
<Component Id="cmp3CC027D3F160412C9F0044EBED3115DD" Guid="{8D7CAA67-8F28-422C-85FB-BDE04902E64F}">
<File Id="filFD2EF6BC74AF459D1BB52CA1E8C6E33B" KeyPath="yes" Source="$(env.ProductSourcePath)\NJsonSchema.dll" />
</Component>
<Component Id="cmp98A11B3F71BACCA2DD0A4856577CD343" Guid="{4EFB61AC-361B-42D0-B9A1-C1FEE287CD13}">
<File Id="fil9286A659888A5C12030A9CF0B215D062" KeyPath="yes" Source="$(env.ProductSourcePath)\Microsoft.CodeAnalysis.VisualBasic.dll" />
</Component>
<Component Id="cmp85032A09199C30E63F9F2CF55B6FA9B9" Guid="{D3414CD0-7366-4008-A406-DC9E69224F42}">
<File Id="fil85032A09199C30E63F9F2CF55B6FA9B9" KeyPath="yes" Source="$(env.ProductSourcePath)\System.Memory.dll" />
</Component>
Expand Down Expand Up @@ -1828,6 +1831,7 @@
<Fragment>
<ComponentGroup Id="$(var.ProductDirectoryName)">
<ComponentRef Id="cmp3CC027D3F160412C9F0044EBED3115DD" />
<ComponentRef Id="cmp98A11B3F71BACCA2DD0A4856577CD343" />
<ComponentRef Id="cmp85032A09199C30E63F9F2CF55B6FA9B9" />
<ComponentRef Id="cmp12FFA2A71C4F95630792652F192DAAB3" />
<ComponentRef Id="cmp3B130879A26D2E954251BB81E8948069" />
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.PowerShell.Commands.Utility/Microsoft.PowerShell.Commands.Utility.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="2.7.0" />
<PackageReference Include="Microsoft.CodeAnalysis.VisualBasic" Version="2.7.0" />
<PackageReference Include="NJsonSchema" Version="9.9.10" />
</ItemGroup>

Expand Down
Loading