Skip to content

Msi installer: smoke test #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 6 commits into from
Feb 7, 2018
Merged

Msi installer: smoke test #6105

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2b7c10a
add smoke test for msi installer
bergmeister Feb 5, 2018
cef0a06
add -verbose switch and more logging
bergmeister Feb 5, 2018
f6530b8
add blocking install
bergmeister Feb 5, 2018
043076a
forgot to return process. tidy up and make sure appveyor would really…
bergmeister Feb 5, 2018
d5e6a0b
address pr comment
bergmeister Feb 5, 2018
da89fce
Add comment to explain the call to 'SetShouldExit'
daxian-dbw Feb 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tools/appveyor.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ function Get-ReleaseTag
# Implements AppVeyor 'on_finish' step
function Invoke-AppveyorFinish
{
$exitCode = 0
try {
$releaseTag = Get-ReleaseTag

Expand Down Expand Up @@ -474,6 +475,19 @@ function Invoke-AppveyorFinish
$preReleaseVersion = "$previewPrefix-$previewLabel.$env:APPVEYOR_BUILD_NUMBER"
}

# Smoke Test MSI installer
Write-Verbose "Smoke-Testing MSI installer" -Verbose
$msi = $artifacts | Where-Object { $_.EndsWith(".msi") }
$msiLog = Join-Path (Get-Location) 'msilog.txt'
$msiExecProcess = Start-Process msiexec.exe -Wait -ArgumentList "/I $msi /quiet /l*vx $msiLog" -NoNewWindow -PassThru
Copy link
Collaborator

@iSazonov iSazonov Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it run with elevated privileges?

Copy link
Contributor Author

@bergmeister bergmeister Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes (otherwise it would fail)

if ($msiExecProcess.ExitCode -ne 0)
{
Push-AppveyorArtifact msiLog.txt
$exitCode = $msiExecProcess.ExitCode
throw "MSI installer failed and returned error code $exitCode. MSI Log was uploaded as artifact."
Copy link
Member

@TravisEz13 TravisEz13 Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps just call Add-Appveyor test with the results?

see https://github.com/PowerShell/DscResource.Tests/blob/f9e3dfd3eb9d7b6a9225e2cfba68b79ffe1cab36/AppVeyor.psm1#L459

Copy link
Contributor Author

@bergmeister bergmeister Feb 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried this in a test branch but although the test shows up as red, the build is still green: https://ci.appveyor.com/project/bergmeister/powershell/build/v6.1.0-preview.281/tests

Copy link
Member

@TravisEz13 TravisEz13 Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I see and the DSC code solves this by throwing...

Copy link
Contributor Author

@bergmeister bergmeister Feb 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sure about the fact that it actually 'solves' it because throwing still does not make the build red. See here
Even uploading a failed test result and adding a throw statement in my 2nd branch here does not make the build red, hence my approach with the exit code as per link with the discussion above.
image

Copy link
Member

@TravisEz13 TravisEz13 Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's because we are in the finish.

Copy link
Member

@TravisEz13 TravisEz13 Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this not be a Pester test that requires admin?

Copy link
Contributor Author

@bergmeister bergmeister Feb 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you build all your packages in the finish step when calling Start-PSPackage as far as I can see (i.e. the MSI would not be built at this point in time yet). Changing this looks like a major refactoring that is outside the scope of this PR. I don't understand what worries you about exiting at the shell at the end since this cmdlet is AppVeyor specific and therefore only meant to be run on AppVeyor? The same thing has to be done to PowerShell scripts that are being run in VSTS builds.

Copy link
Member

@TravisEz13 TravisEz13 Feb 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... forgot about that....

}
Write-Verbose "MSI smoke test was successful" -Verbose

# only publish assembly nuget packages if it is a daily build and tests passed
if((Test-DailyBuild) -and $env:TestPassed -eq 'True')
{
Expand Down Expand Up @@ -527,4 +541,13 @@ function Invoke-AppveyorFinish
catch {
Write-Host -Foreground Red $_
}
finally {
# A throw statement would not make the build fail. This function is AppVeyor specific
# and is the only command executed in 'on_finish' phase, so it's safe that we request
# the current runspace to exit with the specified exit code. If the exit code is non-zero,
# AppVeyor will fail the build.
# See this link for details:
# https://help.appveyor.com/discussions/problems/4498-powershell-exception-in-test_script-does-not-fail-build
$host.SetShouldExit($exitCode)
}
}