Fix update help tests for PSReadline #5980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path for PSReadline after updating has a module version. The tests needed to be updated.
daxian-dbw
approved these changes
Jan 22, 2018
Member
|
@adityapatwardhan There are failures in Travis CI runs. Please take a look. |
9 tasks
Member
Author
|
I suspect they are due to newer version on PSReadline. Having a look. |
Member
Author
|
cc @TravisEz13 The failures in Console tests are due upgrading the PSReadline version to v2.0.0.-beta1. We need to revert the change #5759 |
Member
|
Close this PR as we are reverting #5759, which introduced the failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #5973
The path for PSReadline after updating has a module version. The tests needed to be updated.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.