packaging: Windows installer to use HKLM instead of HKCU registry keys since current installation scope is perMachine #5915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scope is perMachine.
Collaborator
|
I restarted CI Travis Linux. |
iSazonov
approved these changes
Jan 16, 2018
SteveL-MSFT
approved these changes
Jan 16, 2018
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Mar 13, 2018
… scope is perMachine. (PowerShell#5915) # Conflicts: # assets/Product.wxs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Use HKLM instead of HKCU registry keys since the current installation scope is perMachine.
@saschanaz spotted this originally for the app path registration in issue #5905 but it also applies to the startmenu shortcut
Of course we could also have a checkbox to let the user decide if the registrations should be on a per user or per machine basis but I don't think this is worth the effort.
Fixes #5905
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.