-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Update PowerShell to build with .NET Core 2.0.5 #5903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PowerShell to build with .NET Core 2.0.5 #5903
Conversation
|
Pleas push a commit with |
7cdf37f to
8b375cf
Compare
|
Do we need to mention the 2 important security fixes that come with 2.0.5 in the documents?
Can someone review their severity/impact and decide whether this also means that 6.0 needs to have a patch with this update? @LeeHolmes |
| image: Visual Studio 2017 | ||
|
|
||
| # cache version - netcoreapp.2.0.4 | ||
| # cache version - netcoreapp.2.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to drop one of the caches (maybe in a separate PR)? I have seen recently that we always hit the 1GB limit of AppVeyor where it tries to upload it but then fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
touching the appveory.yml should cause the cache to rebuild.
|
Should we also update the SDK in the global.json from |
|
I think could we move to latest SDK (2.1.4) after GA 6.0.1 to get up to date the 6.0.0 servicing branch. Interesting, will we be able to move to CoreFX 2.1.0 preview version in our development branch - this version already contains many performance improvements and we could use new C# 7.2. |
|
@LeeHolmes @PaulHigin @SteveL-MSFT can you please take a look at the comment #5903 (comment) and see if there's any implication on PS Core 6.0.0? |
|
We should take dotnetcore 2.0.5 as part of 6.0.1 release |
|
@SteveL-MSFT OK. On a related note: The WiX toolset also had a security patch 2 weeks ago: https://www.firegiant.com/blog/2017/12/31/wix-v3.10.4-and-wix-v3.11.1-released/ |
|
It seems we use WiX from AppVeyor base image - so the issue is for AppVeyor. |
|
Yes, but I guess that MSFT uses their own servers for building the GA release. This was a remark about the upcoming patch release. |
|
@iSazonov I am confused, the global.json still refers to |
|
@bergmeister It is a trick - we use different versions of runtime and CLI. See @daxian-dbw comment. What I would really like to see is that we could start using C# 7.2 and Span/Memory (used runtime 2.0.* already contains Span support). |
PR Summary
Use new .Net Core servicing build 2.0.5.
https://github.com/dotnet/cli/releases
https://blogs.msdn.microsoft.com/dotnet/2018/01/09/net-core-january-2018-update/
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.