Skip to content

Conversation

@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Jan 15, 2018

PR Summary

Use new .Net Core servicing build 2.0.5.
https://github.com/dotnet/cli/releases
https://blogs.msdn.microsoft.com/dotnet/2018/01/09/net-core-january-2018-update/

PR Checklist

Note: Please mark anything not applicable to this PR NA.

@markekraus
Copy link
Contributor

Pleas push a commit with [Feature] in the commit message.

@iSazonov iSazonov force-pushed the update-dotnetcore-2.0.5 branch from 7cdf37f to 8b375cf Compare January 15, 2018 12:54
@bergmeister
Copy link
Contributor

bergmeister commented Jan 15, 2018

Do we need to mention the 2 important security fixes that come with 2.0.5 in the documents?

Can someone review their severity/impact and decide whether this also means that 6.0 needs to have a patch with this update? @LeeHolmes

image: Visual Studio 2017

# cache version - netcoreapp.2.0.4
# cache version - netcoreapp.2.0.5
Copy link
Contributor

@bergmeister bergmeister Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to drop one of the caches (maybe in a separate PR)? I have seen recently that we always hit the 1GB limit of AppVeyor where it tries to upload it but then fails.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

touching the appveory.yml should cause the cache to rebuild.

@bergmeister
Copy link
Contributor

bergmeister commented Jan 15, 2018

Should we also update the SDK in the global.json from 2.0.2 to 2.0.3, which is already in the used AppVeyor image VisualStudio2017?

@iSazonov
Copy link
Collaborator Author

I think could we move to latest SDK (2.1.4) after GA 6.0.1 to get up to date the 6.0.0 servicing branch.

Interesting, will we be able to move to CoreFX 2.1.0 preview version in our development branch - this version already contains many performance improvements and we could use new C# 7.2.

@daxian-dbw daxian-dbw requested a review from PaulHigin January 16, 2018 17:29
@daxian-dbw
Copy link
Member

@LeeHolmes @PaulHigin @SteveL-MSFT can you please take a look at the comment #5903 (comment) and see if there's any implication on PS Core 6.0.0?

@TravisEz13 TravisEz13 merged commit 89bdb17 into PowerShell:master Jan 17, 2018
@SteveL-MSFT
Copy link
Member

We should take dotnetcore 2.0.5 as part of 6.0.1 release

@iSazonov iSazonov deleted the update-dotnetcore-2.0.5 branch January 17, 2018 02:59
@bergmeister
Copy link
Contributor

@SteveL-MSFT OK. On a related note: The WiX toolset also had a security patch 2 weeks ago: https://www.firegiant.com/blog/2017/12/31/wix-v3.10.4-and-wix-v3.11.1-released/

@iSazonov
Copy link
Collaborator Author

It seems we use WiX from AppVeyor base image - so the issue is for AppVeyor.

@bergmeister
Copy link
Contributor

Yes, but I guess that MSFT uses their own servers for building the GA release. This was a remark about the upcoming patch release.

TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Jan 17, 2018
@TravisEz13 TravisEz13 added this to the 6.0.1 milestone Jan 18, 2018
@bergmeister
Copy link
Contributor

bergmeister commented Jan 20, 2018

@iSazonov I am confused, the global.json still refers to 2.0.2 and the documentation on it here says that this is the SDK (not the runtime version). This SDK version contains the old 2.0.0. version of the .Net Runtime, see docs here
Do we not need to update the string to 2.1.4, which is the SDK containing the 2.0.5 runtime, see docs here?

@iSazonov
Copy link
Collaborator Author

@bergmeister It is a trick - we use different versions of runtime and CLI. See @daxian-dbw comment.
RuntimeFrameworkVersion really set minimal patch version of .Net Core runtime.
(I found great design docs https://github.com/dotnet/designs/issues/3)

What I would really like to see is that we could start using C# 7.2 and Span/Memory (used runtime 2.0.* already contains Span support).
Also interesting when we can use .Net Core 2.1.0 - they have already done a lot to increase performance and continue to increase it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants