Fix escape string translation when generating a resx file from the PowerShell ETW manifest #5892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantraMSFT
requested review from
TravisEz13 and
adityapatwardhan
as code owners
Contributor
|
How about just using my original suggestion: #5144 (comment) |
Contributor
Author
|
@daxian-dbw, @TravisEz13, @adityapatwardhan: Do you guys have any feedback on this? |
daxian-dbw
approved these changes
Jan 18, 2018
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
The updated resource strings look good to me.
adityapatwardhan
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #5890
The original resx generator misconfigured the translation table for translating message resource escape characters to string escape characters. The change fixes the escapeStrings table and includes the regenerated resx file.
The resx file is used on Linux and MacOS for writing the equivalent of ETW events to the system log files.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.