Remove sc alias which conflicts with sc.exe #5827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
approved these changes
Jan 8, 2018
daxian-dbw
reviewed
Jan 8, 2018
Member
There was a problem hiding this comment.
Windows PowerShell only aliases are also included here so this table is a complete source of alias changes. So maybe this entry should be kept and only change the 4th column to be $($FullCLR ) like scb.
Member
Author
There was a problem hiding this comment.
Yes, I'll make that change until we completely remove the Windows PowerShell code :)
daxian-dbw
approved these changes
Jan 9, 2018
8 tasks
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Jan 9, 2018
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
SC is a default alias for Set-Content, however on Windows there is a sc.exe command for managing NT Services.
If a user executes
sc start service1in a PowerShell script, what happens is that a file calledstartis created containingservice1as the content with no error so the user/script may think the service got started.In addition, there is also a
sccommand on Linux, although it's not installed by default.If the customer feedback is that we should not have removed this, it'll be easier to add it back in 6.1.0 than to ever try to remove it after 6.0.0.
Fix is to remove
scalias from InitialSessionState and corresponding test case.This was discussed with some members of @PowerShell/powershell-committee whom agreed to the removal.
Doc change MicrosoftDocs/PowerShell-Docs#2021
Fix #3980
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affects feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.