Developer documentation update for git submodules #5786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n git submodule docs/FAQ.md with the only left over submodule src/libpsl-native/test/googletest
Collaborator
|
Googletests has a nuget package https://www.nuget.org/packages/googletest/ - we could remove the submodule too. |
TravisEz13
approved these changes
Jan 5, 2018
Member
|
@iSazonov could you file an issue for that? |
TravisEz13
added
the
Area-Maintainers-Documentation
TravisEz13
pushed a commit
that referenced
this pull request
Jan 6, 2018
Since Pester is not a submodule anymore, replace submodule example in git submodule docs/FAQ.md with the only leftover submodule src/libpsl-native/test/googletest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Since Pester is not a submodule any more, replace submodule example in git submodule docs/FAQ.md with the only left over submodule src/libpsl-native/test/googletest
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.