Minor docker release tests updates #5692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmenaga
requested review from
adityapatwardhan and
daxian-dbw
as code owners
Member
|
Maybe this PR should target the |
TravisEz13
requested changes
Dec 14, 2017
| $buildArgs += "--build-arg","$versionStubName=$versionStubValue" | ||
| $buildArgs += "--build-arg","$testlistStubName=$testlistStubValue" | ||
| $buildArgs += "--build-arg","$packageLocationStubName=$packageLocationStubValue" | ||
| $buildArgs += "--no-cache" |
Member
There was a problem hiding this comment.
Please don't do this. This will make the other tests very slow. Please fix your docker files, or make this an option, that only your tests use.
daxian-dbw
approved these changes
Dec 14, 2017
TravisEz13
approved these changes
Dec 15, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 19, 2017
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR has 2 updates to release docker tests:
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.