Skip to content

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Dec 13, 2017

PR Summary

Update scripts and documentation with RC.2 version

PR Checklist

Note: Please mark anything not applicable to this PR NA.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary archive chart needs to be updated with linux-arm, win-arm and win-arm64 packages

@daxian-dbw daxian-dbw requested a review from anmenaga December 13, 2017 22:31
@daxian-dbw
Copy link
Member

I searched rc- in linux.md and found 15 instances. We need to change those instances to rc.2-

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.0.0-rc/ needs to be updated.
There are 15 instances of 6.0.0-rc/ in linux.md.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And some of 6.0.0-rc instances like this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/powershell6.0.0-rc.2

It should be /powershell/6.0.0-rc.2. There are 4 instances of it.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use Windows (arm) *Experimental*? See Steve's changes in #5682

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TravisEz13 you should merge the changes to the README.md from my PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of put in the package chart, maybe it's better to put all tarball/zipball related info in the binary archive chart (that's what Travis does in this PR).

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, maybe use Raspbian (Stretch) *Experimental*. See #5682

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the two Experimental arm platforms one after the other so they are visibly together/related

@TravisEz13 TravisEz13 merged commit 02cc3db into PowerShell:6.0.0 Dec 14, 2017
@TravisEz13 TravisEz13 deleted the update_version branch December 14, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants