Skip to content

Conversation

@SteveL-MSFT
Copy link
Member

PR Summary

Update README.md to include win-arm build and link to installation instructions. Add section to windows.md installation instructions specifically for Windows IoT. Added Experimental labels to win-arm and linux-arm packages since dotnetcore doesn't formally support them yet and we haven't fully tested them.

PR Checklist

Note: Please mark anything not applicable to this PR NA.

Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Travis CI detected spelling error in this line about "PSSession".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PSSession is a class name, so maybe we should put it in a code block (enclose it with ``). If so, we don't need to change the .spelling file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, will change.

@SteveL-MSFT SteveL-MSFT modified the milestones: 6.0.0-RC.2, 6.0.0-GA Dec 13, 2017
Copy link

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis updated the readme.md to include win-arm32 and win-arm64 zip packages in #5688. Can you please review that and give your feedback?

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 comments.

@daxian-dbw daxian-dbw dismissed their stale review December 14, 2017 23:42

New commit has been pushed.

@daxian-dbw
Copy link
Member

@SteveL-MSFT Travis has incorporated your changes in README.md in his PR (which has been merged), so you can revert the changes in README.md.

@SteveL-MSFT
Copy link
Member Author

@daxian-dbw removed README.md from this PR

@daxian-dbw daxian-dbw merged commit 462833b into PowerShell:master Dec 15, 2017
@SteveL-MSFT SteveL-MSFT deleted the install-winarm branch December 15, 2017 22:25
TravisEz13 pushed a commit to TravisEz13/PowerShell that referenced this pull request Dec 19, 2017
@TravisEz13 TravisEz13 mentioned this pull request Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants