-
Notifications
You must be signed in to change notification settings - Fork 8.1k
add instructions to deploy PSCore6 on Windows IoT arm32 #5682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
anmenaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment
docs/installation/windows.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Travis CI detected spelling error in this line about "PSSession".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSSession is a class name, so maybe we should put it in a code block (enclose it with ``). If so, we don't need to change the .spelling file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion, will change.
anmenaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis updated the readme.md to include win-arm32 and win-arm64 zip packages in #5688. Can you please review that and give your feedback?
daxian-dbw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 2 comments.
aa2f73d to
7f1ecd6
Compare
|
@SteveL-MSFT Travis has incorporated your changes in |
7f1ecd6 to
7b2872e
Compare
|
@daxian-dbw removed README.md from this PR |
PR Summary
Update README.md to include win-arm build and link to installation instructions. Add section to windows.md installation instructions specifically for Windows IoT. Added Experimental labels to win-arm and linux-arm packages since dotnetcore doesn't formally support them yet and we haven't fully tested them.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.