Make the experience better when start-pspester doesn't find pester #5673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e build.psm1 has been imported (try to use the default options)
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
markekraus
approved these changes
Dec 12, 2017
Contributor
markekraus
left a comment
markekraus
left a comment
There was a problem hiding this comment.
LGTM and Thank you!!!
Member
|
Can you address #5640 in the same PR? |
Member
Author
|
Added two commits for the docs. One to make them pass unit tests and one to make the updates for easier review. |
markekraus
approved these changes
Dec 12, 2017
SteveL-MSFT
requested changes
Dec 12, 2017
build.psm1
Outdated
| Pester module not found. | ||
| Make sure that the proper git submodules are installed by running: | ||
| git submodule update --init | ||
| Restore to module to '$Pester' by running: |
SteveL-MSFT
approved these changes
Dec 12, 2017
TravisEz13
force-pushed
the
fix_pester_restore
branch
from
a52add8 to
17a1f6c
Compare
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 13, 2017
…owerShell#5673) refactor code to restore pester into a separate function called Restore-PSPester update message on what to do when pester is missing Add ability for get-psoptions to default to new-psoptions fix an issue with publish-pstesttools when a build has not been run since build.psm1 has been imported (try to use the default options) make start-pspester use the last build, not just use the default options fix an issue in restore caused some files not to be removed
TravisEz13
added a commit
that referenced
this pull request
Dec 13, 2017
…5673) refactor code to restore pester into a separate function called Restore-PSPester update message on what to do when pester is missing Add ability for get-psoptions to default to new-psoptions fix an issue with publish-pstesttools when a build has not been run since build.psm1 has been imported (try to use the default options) make start-pspester use the last build, not just use the default options fix an issue in restore caused some files not to be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
get-psoptionsto default tonew-psoptionspublish-pstesttoolswhen a build has not been run since build.psm1 has been imported (try to use the default options)start-pspesteruse the last build, not just use the default optionsPR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature testsWIP:to the beginning of the title and remove the prefix when the PR is ready.