Skip to content

Update a flaky test that fails intermittently in CI #5641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Dec 6, 2017
Merged

Update a flaky test that fails intermittently in CI #5641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62d534b
Update flaky test
daxian-dbw Dec 6, 2017
da9cd9e
Address comment
daxian-dbw Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions test/powershell/engine/Basic/ValidateAttributes.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,15 @@ Describe 'Validate Attributes Tests' -Tags 'CI' {
$byteList = [System.Collections.Generic.List[byte]] $byteArray
$byteCollection = [System.Collections.ObjectModel.Collection[byte]] $byteArray
## Use the running time of 'MandatoryFunc -Value $byteArray' as the baseline time
## because it does no check on the argument.
$baseline = (Measure-Command { MandatoryFunc -Value $byteArray }).Milliseconds
## Running time should be less than 'expected'
$expected = $baseline + 20
## Running time should be less than 'UpperBoundTime'
## This is not really a performance test (perf test cannot run reliably in our CI), but a test
## to make sure we don't check the elements of a value-type collection.
## The crossgen'ed 'S.M.A.dll' is about 28mb in size, and it would take more than 2000ms if we
## check each byte of the array, list or collection. We use ($baseline + 200)ms as the upper
## bound value in tests to prove that we don't check each byte.
$UpperBoundTime = $baseline + 200

if ($IsWindows) {
$null = New-Item -Path $TESTDRIVE/file1
Expand All @@ -340,7 +346,7 @@ Describe 'Validate Attributes Tests' -Tags 'CI' {

It "Validate running time '<ScriptBlock>'" -TestCases $testCases {
param ($ScriptBlock)
(Measure-Command $ScriptBlock).Milliseconds | Should BeLessThan $expected
(Measure-Command $ScriptBlock).Milliseconds | Should BeLessThan $UpperBoundTime
}

It "COM enumerable argument should work with 'ValidateNotNull' and 'ValidateNotNullOrEmpty'" -Skip:(!$IsWindows) {
Expand Down