Update a flaky test that fails intermittently in CI #5641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
changed the title
adityapatwardhan
approved these changes
Dec 6, 2017
anmenaga
suggested changes
Dec 6, 2017
| ## The crossgen'ed 'S.M.A.dll' is about 28mb in size, and it would take over 2000ms if we check | ||
| ## each byte of the array, list or collection. We use 200ms as the upper bound value in tests to | ||
| ## prove that we don't check each byte. | ||
| $UpperBoundTime = 200 |
There was a problem hiding this comment.
Previous implementation used some MandatoryFunc to establish a reasonable baseline with adding some extra time to that.
Can $UpperBoundTime use similar runtime-calculated baseline (and adding something on top of that) rather than a constant?
Member
Author
There was a problem hiding this comment.
I guess I can add back the baseline and add 200 ms to it
JamesWTruher
approved these changes
Dec 6, 2017
Collaborator
JamesWTruher
left a comment
JamesWTruher
left a comment
There was a problem hiding this comment.
200ms seems reasonable
Member
Author
|
@anmenaga You comment has been addressed. Can you please take another look? |
anmenaga
approved these changes
Dec 6, 2017
Member
Author
|
Thanks all for the review! Since the flaky test could fail in other PR CI runs at any time, I will merge this PR without waiting for 24 hours. |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 7, 2017
TravisEz13
pushed a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Close #5627
Update a flaky test that fails intermittently in our CI builds:
The tests were added along with the fix for the issue #5417. The tests are to validate that we don't check each element of a value-type collection argument.
This fix is to increase the upper bound of the expected time to 200ms, which is still way less than the time it would take before the fix -- more than 2000ms for a byte collection of 28mb in size.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.[feature]if the change is significant or affectes feature tests