Minor refactoring of the release build scripts #5632
Merged
+23
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapatwardhan
approved these changes
Dec 5, 2017
TravisEz13
reviewed
Dec 5, 2017
tools/releaseBuild/build.json
Outdated
| ".\\tools\\releaseBuild\\Images\\microsoft_powershell_windowsservercore\\dockerInstall.psm1" | ||
| ], | ||
| "DockerImageName": "ps-winsrvcore", | ||
| "BinaryBucket": "symbols", |
Member
There was a problem hiding this comment.
if we change the containerfolder in the other PR, we need to change the binarybucker where it equals symbols to results
Member
Author
There was a problem hiding this comment.
Yes, the other PR has been updated. I also changed BinaryBucket to results for the -symbols entries.
Member
|
@TravisEz13 Can you have another look? |
TravisEz13
approved these changes
Dec 6, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 7, 2017
* Update release build * Minor refactoring of the build script
TravisEz13
pushed a commit
that referenced
this pull request
Dec 7, 2017
* Update release build * Minor refactoring of the build script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Note: Please mark anything not applicable to this PR
NA.win-armandwin-arm64packages needs to.[feature]if the change is significant or affectes feature testsPR Summary
Some name changes, comment updates, and random fixes.
This depends on PowerShell/PSRelease#28 to be merged.