Merge 6.0.0 rc.2 changes #5606
Merged
Merge 6.0.0 rc.2 changes #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial work to enable xunit * Moved AssemblyOriginatorKeyFile to csharp.tests.csproj * Native binary has dylib extension on macOS
PowerShell#5432) * Fix NotNullOrEmpty check logic * Fix a test issue on Unix
… use the current (PowerShell#5596) Remove unnecessary check for Paths.count > 0 as there is code later to use the current working directory since -Path is not a mandatory parameter. Updated ShouldProcess to output the internal action on adding paths rather than the user action (which is the cmdlet name). Updated tests to not specify -Path Fix PowerShell#5594
TravisEz13
requested review from
BrucePay,
adityapatwardhan,
daxian-dbw and
lzybkr
as code owners
daxian-dbw
approved these changes
Dec 2, 2017
SteveL-MSFT
approved these changes
Dec 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following PR to 6.0.0-rc.2:
#5580
#4780
#5432
#5593
#5595
#5596