-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Merge 6.0.0 ga changes #5573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge 6.0.0 ga changes #5573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix expected vs actual for easier troubleshooting * replace strlen calls with strnlen
Add checks that ProcessName is not null or empty.
* Disambiguate icon for daily builds on Windows. Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576
* updated install link and instructions for R-Pi * remove libicu57 as it's not needed
* XML documentation fix for CompletionResult: 1 typo, make text start with upper case and add periods at the end. This typo showed up on the official docs site: https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.completionresult.-ctor?view=powershellsdk-1.1.0#System_Management_Automation_CompletionResult__ctor_System_String_ * Add periods to private members as well as suggested in PR.
…Shell#5498) This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January. It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well. The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
daxian-dbw
approved these changes
Nov 29, 2017
adityapatwardhan
approved these changes
Nov 29, 2017
SteveL-MSFT
approved these changes
Nov 29, 2017
Member
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the PRs being taken wasn't marked for 6.0.0-GA. I fixed that. We should be consistent on adding the milestone for PRs that we believe are appropriate for GA so that the author of the PR is aware.
Member
Author
|
restarted macOS due to a random homebrew failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge PRs
#5510
#5521
#5467
#5538
#5537
#5495
#5527
#5547
#5550
#5529
#5498
#5459