Skip to content

Conversation

@TravisEz13
Copy link
Member

TravisEz13 and others added 12 commits November 28, 2017 16:49
* fix expected vs actual for easier troubleshooting
* replace strlen calls with strnlen
Add checks that ProcessName is not null or empty.
* Disambiguate icon for daily builds on Windows.
Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576
* updated install link and instructions for R-Pi
* remove libicu57 as it's not needed
* XML documentation fix for CompletionResult: 1 typo, make text start with upper case and add periods at the end.
This typo showed up on the official docs site: https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.completionresult.-ctor?view=powershellsdk-1.1.0#System_Management_Automation_CompletionResult__ctor_System_String_

* Add periods to private members as well as suggested in PR.
…Shell#5498)

This resolves issue PowerShell#5391, which is tagged with 6.0.0-GA, therefore this should help with getting pwsh out of the door in January.

It removes PerformWSManPluginReportCompletion as stated in the issue and its associated class member g_pPluginContext, which is now unused as well.

The best reviewer is probably @mirichmo , who raised the initial issue with very helpful descriptions or @dantraMSFT who is currently assigned to the issue.
reducing the base image size should make the build a little faster
Also, remove the duplicate upload of a file
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the PRs being taken wasn't marked for 6.0.0-GA. I fixed that. We should be consistent on adding the milestone for PRs that we believe are appropriate for GA so that the author of the PR is aware.

@TravisEz13
Copy link
Member Author

restarted macOS due to a random homebrew failure

@TravisEz13 TravisEz13 merged commit 8ec31af into PowerShell:6.0.0 Nov 29, 2017
@TravisEz13 TravisEz13 deleted the 6.0.0-GA_changes branch November 29, 2017 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants