Skip to content

Update test to construct the version from $PSVersionTable.PSVersion #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
daxian-dbw wants to merge 1 commit into from
Closed

Update test to construct the version from $PSVersionTable.PSVersion #5557

daxian-dbw wants to merge 1 commit into from

Conversation

@daxian-dbw
Copy link
Member

@daxian-dbw daxian-dbw commented Nov 28, 2017

Two tests related to *-PSSessionConfiguration failed (see the failure below). The tests failed because the powershell built from the master branch is now with the version v6.1.0-preview.1, but we hardcoded the expected version to be 6.0. The fix is to generate the expected version from $PSVersionTable.PSVersion.

Describing Validate Register-PSSessionConfiguration, Set-PSSessionConfiguration cmdlets
   Context Validate Register-PSSessionConfiguration
    [-] Validate Register-PSSessionConfiguration -name -path 14.51s
      Expected: {6}
      But was:  {6.1}
      at line: 491 in C:\projects\powershell-f975h\test\powershell\Modules\Microsoft.PowerShell.Core\PSSessionConfiguration.Tests.ps1
      491:                     $Result.Session.PSVersion | Should be 6.0
   Context Validate Set-PSSessionConfiguration
    [-] Validate Set-PSSessionConfiguration -name -path -MaximumReceivedObjectSizeMB -MaximumReceivedDataSizePerCommandMB -UseSharedProcess -ThreadOptions parameters 27.69s
      Expected: {6}
      But was:  {6.1}
      at line: 560 in C:\projects\powershell-f975h\test\powershell\Modules\Microsoft.PowerShell.Core\PSSessionConfiguration.Tests.ps1
      560:                     $Result.Session.PSVersion | Should be 6.0

@adityapatwardhan
Copy link
Member

adityapatwardhan commented Nov 28, 2017

@daxian-dbw There is a PR open to resolve the issue. #5554

@daxian-dbw
Copy link
Member Author

daxian-dbw commented Nov 28, 2017

@adityapatwardhan Ah, thanks. I forgot it.

@daxian-dbw daxian-dbw closed this Nov 28, 2017
@daxian-dbw daxian-dbw deleted the FixCI branch November 28, 2017 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@adityapatwardhan adityapatwardhan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxian-dbw @adityapatwardhan