XML documentation fix for CompletionResult #5550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith upper case and add periods at the end. This typo showed up on the official docs site: https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.completionresult.-ctor?view=powershellsdk-1.1.0#System_Management_Automation_CompletionResult__ctor_System_String_
bergmeister
requested review from
BrucePay,
daxian-dbw and
lzybkr
as code owners
markekraus
approved these changes
Nov 26, 2017
Collaborator
|
@bergmeister Thanks for your contribution! Could you please check the remaining |
iSazonov
approved these changes
Nov 27, 2017
markekraus
approved these changes
Nov 27, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
* XML documentation fix for CompletionResult: 1 typo, make text start with upper case and add periods at the end. This typo showed up on the official docs site: https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.completionresult.-ctor?view=powershellsdk-1.1.0#System_Management_Automation_CompletionResult__ctor_System_String_ * Add periods to private members as well as suggested in PR.
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Nov 29, 2017
* XML documentation fix for CompletionResult: 1 typo, make text start with upper case and add periods at the end. This typo showed up on the official docs site: https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.completionresult.-ctor?view=powershellsdk-1.1.0#System_Management_Automation_CompletionResult__ctor_System_String_ * Add periods to private members as well as suggested in PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally spotted on the official docs website here.
The
listItemTextparameter has a typo: since it says:he text to be displayed in a listAs part of this I also made sure that all comment start with an upper case and added periods at the end of all comments in this file.
On a minor note: The
Editbutton on the official docs website here is not working.