Skip to content

remove signed folder in zip after copying signed binaries for packaging #5527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TravisEz13 merged 1 commit into from
Nov 28, 2017
Merged

remove signed folder in zip after copying signed binaries for packaging #5527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/packaging/packaging.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,12 @@ function New-PSSignedBuildZip
Copy-Item -Path $_ -Destination $destination -force
}

# Remove `signed` folder in buildpath now that signed binaries are copied
if (Test-Path $BuildPath\signed)
{
Copy link
Contributor

@bergmeister bergmeister Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the brace on the same line as this seems to be the most common style? I have opened PR #5529 to help with the style in the future.

Copy link
Member Author

@SteveL-MSFT SteveL-MSFT Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed both styles in this file, but it seems that for if statements, at least near the code I added, the braces were on a new line

Remove-Item -Recurse -Force -Path $BuildPath\signed
}

$name = split-path -Path $BuildPath -Leaf
$zipLocationPath = Join-Path -Path $DestinationFolder -ChildPath "$name-signed.zip"
Compress-Archive -Path $BuildPath\* -DestinationPath $zipLocationPath
Expand Down