remove signed folder in zip after copying signed binaries for packaging
#5527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested review from
adityapatwardhan and
daxian-dbw
as code owners
bergmeister
reviewed
Nov 22, 2017
|
|
||
| # Remove `signed` folder in buildpath now that signed binaries are copied | ||
| if (Test-Path $BuildPath\signed) | ||
| { |
Contributor
There was a problem hiding this comment.
Maybe put the brace on the same line as this seems to be the most common style? I have opened PR #5529 to help with the style in the future.
Member
Author
There was a problem hiding this comment.
I noticed both styles in this file, but it seems that for if statements, at least near the code I added, the braces were on a new line
TravisEz13
approved these changes
Nov 28, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that signing puts the signed binaries in a folder called signed. The current packaging copies the signed binaries over the unsigned binaries, but the signed folder is a child folder of the unsigned binaries so it gets added to the zip resulting in duplicate files that aren't used. Fix is to remove the
signedfolder after copying the signed binaries.Fix #5506