Replace strlen with strnlen in native code #5510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
daxian-dbw
reviewed
Nov 20, 2017
Member
There was a problem hiding this comment.
Can you please explain a bit about why you made the changes to EXPECT_EQ?
Member
Author
There was a problem hiding this comment.
The pattern for EXPECT_EQ is EXPECT_EQ(<expected>,<actual>) when you call it with the parameters reverse it makes the error very confusing.
Member
|
Again, I think we agreed to submit PR targeting master branch, and then cherrypick commits to 6.0.0. Has that process changed? |
TravisEz13
force-pushed
the
fix_StrLen
branch
from
df23197 to
7816ec2
Compare
daxian-dbw
approved these changes
Nov 21, 2017
Member
|
Note that the |
TravisEz13
force-pushed
the
fix_StrLen
branch
from
7816ec2 to
80ba61e
Compare
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
* fix expected vs actual for easier troubleshooting * replace strlen calls with strnlen
Merged
TravisEz13
added a commit
that referenced
this pull request
Nov 29, 2017
* fix expected vs actual for easier troubleshooting * replace strlen calls with strnlen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4975
fix expected vs actual for easier troubleshooting