Added more helpful message for AmbiguousParameterSet exception #5505
Conversation
markekraus
changed the title
| </data> | ||
| <data name="AmbiguousParameterSet" xml:space="preserve"> | ||
| <value>Parameter set cannot be resolved using the specified named parameters.</value> | ||
| <value>Parameter set cannot be resolved using the specified named parameters. One or more parameters issued cannot be used together or an insufficient number of parameters were provided.</value> |
There was a problem hiding this comment.
Not a grammar expert, but the last part of this sentence reads weird to me. I know that were is used with plural nouns, so you would think that because parameters is used, it should be were, but I think the noun here is actually an insufficient number of parameters which is singular (the an gives it away) sort of like ...or an error was provided.. So it seems that it would be ...parameters was provided..
This is not blocking feedback.
There was a problem hiding this comment.
@SteveL-MSFT This is one of those weird English rules. a number of X-es are plural while the number of X-es is singular. In this case we are using an insufficient number of parameters and is the plural form of the phrase. https://en.oxforddictionaries.com/explore/number-of-people-is-or-are
There was a problem hiding this comment.
:-) Now I know who to ask to approve error messages.
There was a problem hiding this comment.
@markekraus Could you please look test failures? It seems HttpListener can not start on 8082 port in Describing Web cmdlets tests using the cmdlet's aliases. Also these tests is "alias" tests - I think we should remove its (we have separate test set for aliases).
|
@kvprasoon Please rebase to get latest updates and pass CIs. |
* use metadata JSON to create release tag in CI
* update expected version * update container list
* fix expected vs actual for easier troubleshooting * replace strlen calls with strnlen
kvprasoon
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
kvprasoon
left a comment
kvprasoon
left a comment
There was a problem hiding this comment.
rebased as appveyor CI fix went in to the base
|
@kvprasoon Please correct the PR - it contains alien commits. It seems you update your fork but don't rebase like |
|
@iSazonov I am not using cmdline, any idea on how to do it via WEB UI ? |
|
@kvprasoon It seems Web UI does not have the capability. |
|
@iSazonov oops, i've messed up something... |
|
@kvprasoon You need to learn Git docs and samples. I started out a year ago like you. |
* use metadata JSON to create release tag in CI
* update expected version * update container list
Add checks that ProcessName is not null or empty.
* Disambiguate icon for daily builds on Windows. Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576
|
@kvprasoon We can not merge the PR until you rebase. |
|
Sorry @iSazonov , my fork is completely messed up, I would re-create and submit. |
|
This will be addressed by https://github.com/PowerShell/PowerShell/pull/5537 |
6 participants
Had issues with my old fork and it got deleted, this issue is to close #5435