Disambiguate icon for daily builds on Windows #5467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576 Tested on Windows 10.0.16299
bergmeister
requested review from
TravisEz13,
adityapatwardhan and
daxian-dbw
as code owners
daxian-dbw
reviewed
Nov 16, 2017
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
Thanks for the improvement! I left a few comments.
tools/install-powershell.ps1
Outdated
| } | ||
|
|
||
| # Edit icon to disambiguate daily builds. | ||
| if ($IsWinEnv -and $Daily.IsPresent) { |
Member
There was a problem hiding this comment.
Can you please move this section up to before the line of if (-not $IsWinEnv) { chmod 755 $Destination/pwsh }? In this way, all manipulations of the executable are grouped together :)
tools/install-powershell.ps1
Outdated
| # Edit icon to disambiguate daily builds. | ||
| if ($IsWinEnv -and $Daily.IsPresent) { | ||
| if (-not (Test-Path "~/.rcedit/rcedit-x64.exe")) { | ||
| Write-Verbose "Install RCEdit for modifying exe resources" |
Member
There was a problem hiding this comment.
Can you please add -Verbose? We use write-verbose -verbose in this file as a way to log useful messages to users. This is a useful message for users to see.
tools/install-powershell.ps1
Outdated
| Invoke-WebRequest -OutFile "~/.rcedit/rcedit-x64.exe" -Uri $rceditUrl | ||
| } | ||
|
|
||
| Write-Verbose "Change icon to disambiguate it from a released installation" |
Member
There was a problem hiding this comment.
Same here. Please add -Verbose.
Contributor
Author
There was a problem hiding this comment.
Done as well now.
…s together. Re-tested that it still works (WMF 5.1, Win10 Fall Creators Update)
daxian-dbw
approved these changes
Nov 16, 2017
Member
|
@SteveL-MSFT Can you please take a look? |
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
* Disambiguate icon for daily builds on Windows. Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576
Merged
TravisEz13
pushed a commit
that referenced
this pull request
Nov 29, 2017
* Disambiguate icon for daily builds on Windows. Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link https://twitter.com/Steve_MSFT/status/930585082451992576
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change icon of
pwsh.exefor daily builds on Windows to this icon.Some code had to be borrowed from build.psm1 because this script has to be self contained in case it gets executed by only downloading this file via the published download link here.
Tested on Windows 10.0.16299 (Fall Creators Update) with WMF 5.1