Update docker file for windows build #5459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
TravisEz13
force-pushed
the
working_signing_fixes
branch
2 times, most recently
from
dc8aa12 to
efae634
Compare
daxian-dbw
reviewed
Nov 16, 2017
Member
There was a problem hiding this comment.
We don't need cmake anymore :)
TravisEz13
force-pushed
the
working_signing_fixes
branch
2 times, most recently
from
e33a005 to
c6c0792
Compare
Member
Author
|
@daxian-dbw @adityapatwardhan Can you update your reviews? |
Member
Author
adityapatwardhan
requested changes
Nov 28, 2017
Member
There was a problem hiding this comment.
Please explain order of lookup in comments.
Member
There was a problem hiding this comment.
Please add comment for brute force
Member
There was a problem hiding this comment.
Please add a comment why we switched to zip instead on MSI, due to it requiring older version of dotnet
Member
There was a problem hiding this comment.
-Force creates destination directory
Member
There was a problem hiding this comment.
Please exclude this change from this PR.
Member
Author
There was a problem hiding this comment.
No, sorry this is a change that is needed. Saw it in reverse when I talked to you.
TravisEz13
force-pushed
the
working_signing_fixes
branch
from
c6c0792 to
db6c02f
Compare
Member
Author
|
Verified release build |
adityapatwardhan
approved these changes
Nov 28, 2017
TravisEz13
added a commit
to TravisEz13/PowerShell
that referenced
this pull request
Nov 29, 2017
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
Merged
TravisEz13
added a commit
that referenced
this pull request
Nov 29, 2017
reducing the base image size should make the build a little faster Also, remove the duplicate upload of a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reducing the base image size should make the build a little faster
Also, remove the duplicate upload of a file