Skip to content

Add standard set of vscode workspace setting files #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Nov 15, 2017
Merged

Add standard set of vscode workspace setting files #5457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3497f3
Add standard set of vscode workspace setting files
rkeithhill Nov 15, 2017
2f3ec05
Clean up grammar
rkeithhill Nov 15, 2017
d438fc9
Instruct VSCode to ensure a final newline.
rkeithhill Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,6 @@ gen
# Per repo profile
.profile.ps1

#VS Code files
.vscode

# macOS
.DS_Store

Expand All @@ -68,4 +65,3 @@ TestsResults*.xml

# Resharper settings
PowerShell.sln.DotSettings.user

11 changes: 11 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
// See http://go.microsoft.com/fwlink/?LinkId=827846
// for the documentation about the extensions.json format
"recommendations": [
Copy link
Collaborator

@iSazonov iSazonov Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub don't like Json comments. I see https://stackoverflow.com/questions/244777/can-comments-be-used-in-json

Should we remove the comments or convert in another form?

Copy link
Collaborator Author

@rkeithhill rkeithhill Nov 15, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps but it didn't stop the VSCode team from checking in json with comments: https://github.com/Microsoft/vscode/blob/master/.vscode/extensions.json
https://github.com/Microsoft/vscode/blob/master/tslint.json

And that comment is the default comment added when you run the Extensions: Configure Recommended Extensions command in VSCode.

Copy link
Collaborator

@iSazonov iSazonov Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If VS Code understands it, I'll merge.

"ms-vscode.cpptools",
"ms-vscode.csharp",
"ms-vscode.PowerShell",
"twxs.cmake",
"DavidAnson.vscode-markdownlint"
]
}
18 changes: 18 additions & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,24 @@
"request": "attach",
"justMyCode": false,
"processId": "${command:pickProcess}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch Current File",
"script": "${file}",
"args": [],
"cwd": "${file}"
},
{
"type": "PowerShell",
"request": "launch",
"name": "PowerShell Launch Current File w/Args Prompt",
"script": "${file}",
"args": [
"${command:SpecifyScriptArgs}"
],
"cwd": "${file}"
}
]
}
22 changes: 22 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Place your settings in this file to overwrite default and user settings.
{
"editor.tabSize": 4,
"editor.insertSpaces": true,

"files.insertFinalNewline": true,

// Based on current .markdownlist.json settings:
// https://github.com/PowerShell/PowerShell/blob/master/.markdownlint.json
"markdownlint.config": {
"MD004": false,
"MD024": false,
"MD033": false,
"MD034": false,
"MD038": false,
"MD042": false
},

"[powershell]": {
"files.trimTrailingWhitespace": true
}
}