-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Add standard set of vscode workspace setting files #5457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard set of vscode workspace setting files #5457
Conversation
Add an extensions.json file that will prompt folks to install extensions that are recommended for this workspace (c++, c#, powershell, cmake (editing syntax) and markdown linter. Add settings.json to start to configure C# syntax, PoweShell trim trailing whitespace and configure the markdown lint extension. Update launch.json to provide ability to debug PowerShell scripts. BTW I'm hoping as more people on the team use the VSCode extension , it will help get more attention to fixing some lingering issues in the PS extension. Dogfooding FTW!!
|
BTW I should have added, the markdown linter integration into VSCode is really, really nice. Much better to see issues while you are editing the markdown files than to wait for the Pester test to find them. :-) |
| "editor.tabSize": 4, | ||
| "editor.insertSpaces": true, | ||
| "markdownlint.config": { | ||
| "MD004": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add comment why these are being excluded?
4ce7828 to
2f3ec05
Compare
SteveL-MSFT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If this is not wanted for certain file types, we can restrict this option to only specified file types.
| { | ||
| // See http://go.microsoft.com/fwlink/?LinkId=827846 | ||
| // for the documentation about the extensions.json format | ||
| "recommendations": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub don't like Json comments. I see https://stackoverflow.com/questions/244777/can-comments-be-used-in-json
Should we remove the comments or convert in another form?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps but it didn't stop the VSCode team from checking in json with comments: https://github.com/Microsoft/vscode/blob/master/.vscode/extensions.json
https://github.com/Microsoft/vscode/blob/master/tslint.json
And that comment is the default comment added when you run the Extensions: Configure Recommended Extensions command in VSCode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If VS Code understands it, I'll merge.
|
Reopen the PR to restart CI Appveyor |
|
@rkeithhill Many thanks for your contribution! |
Add an extensions.json file that will prompt folks to install extensions that are recommended for this workspace (c++, c#, powershell, cmake (editing syntax) and markdown linter.
Add settings.json to start to configure C# syntax, PoweShell trim trailing whitespace and configure the markdown lint extension.
Update launch.json to provide ability to debug PowerShell scripts.
BTW I'm hoping as more people on the team use the VSCode extension , it will help get more attention to fixing some lingering issues in the PS extension. Dogfooding FTW!!