Skip to content

Conversation

@rkeithhill
Copy link
Collaborator

Add an extensions.json file that will prompt folks to install extensions that are recommended for this workspace (c++, c#, powershell, cmake (editing syntax) and markdown linter.

Add settings.json to start to configure C# syntax, PoweShell trim trailing whitespace and configure the markdown lint extension.

Update launch.json to provide ability to debug PowerShell scripts.

BTW I'm hoping as more people on the team use the VSCode extension , it will help get more attention to fixing some lingering issues in the PS extension. Dogfooding FTW!!

Add an extensions.json file that will prompt folks to install extensions that are recommended for this workspace (c++, c#, powershell, cmake (editing syntax) and markdown linter.

Add settings.json to start to configure C# syntax, PoweShell trim trailing whitespace and configure the markdown lint extension.

Update launch.json to provide ability to debug PowerShell scripts.

BTW I'm hoping as more people on the team use the VSCode extension , it will help get more attention to fixing some lingering issues in the PS extension.  Dogfooding FTW!!
@rkeithhill
Copy link
Collaborator Author

rkeithhill commented Nov 15, 2017

BTW I should have added, the markdown linter integration into VSCode is really, really nice. Much better to see issues while you are editing the markdown files than to wait for the Pester test to find them. :-)

"editor.tabSize": 4,
"editor.insertSpaces": true,
"markdownlint.config": {
"MD004": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add comment why these are being excluded?

@rkeithhill rkeithhill force-pushed the rkeithhill/improve-vscode-setup branch from 4ce7828 to 2f3ec05 Compare November 15, 2017 04:21
Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If this is not wanted for certain file types, we can restrict this option to only specified file types.
{
// See http://go.microsoft.com/fwlink/?LinkId=827846
// for the documentation about the extensions.json format
"recommendations": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub don't like Json comments. I see https://stackoverflow.com/questions/244777/can-comments-be-used-in-json

Should we remove the comments or convert in another form?

Copy link
Collaborator Author

@rkeithhill rkeithhill Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps but it didn't stop the VSCode team from checking in json with comments: https://github.com/Microsoft/vscode/blob/master/.vscode/extensions.json
https://github.com/Microsoft/vscode/blob/master/tslint.json

And that comment is the default comment added when you run the Extensions: Configure Recommended Extensions command in VSCode.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If VS Code understands it, I'll merge.

@iSazonov iSazonov self-assigned this Nov 15, 2017
@iSazonov iSazonov closed this Nov 15, 2017
@iSazonov iSazonov reopened this Nov 15, 2017
@iSazonov
Copy link
Collaborator

iSazonov commented Nov 15, 2017

Reopen the PR to restart CI Appveyor

@iSazonov iSazonov merged commit cef7762 into PowerShell:master Nov 15, 2017
@iSazonov
Copy link
Collaborator

@rkeithhill Many thanks for your contribution!

@rkeithhill rkeithhill deleted the rkeithhill/improve-vscode-setup branch May 29, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants