Skip to content

Add HighEntropyVA to building pwsh #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daxian-dbw merged 1 commit into from
Nov 15, 2017
Merged

Add HighEntropyVA to building pwsh #5455

daxian-dbw merged 1 commit into from
Nov 15, 2017

Conversation

@TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Nov 15, 2017

No description provided.

@TravisEz13 TravisEz13 added the Compliance Related to compliance requirements label Nov 15, 2017
@TravisEz13 TravisEz13 added this to the 6.0.0-RC milestone Nov 15, 2017
iSazonov
iSazonov reviewed Nov 15, 2017
View reviewed changes
src/powershell-unix/powershell-unix.csproj Outdated
Copy link
Collaborator

@iSazonov iSazonov Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we don't add this in all csproj files via PowerShell.Common.props?

iSazonov
iSazonov approved these changes Nov 15, 2017
View reviewed changes
Copy link
Collaborator

@iSazonov iSazonov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One minor question. Sometimes msbuild is a surprise. How we can check that the option really works?

@TravisEz13
Copy link
Member Author

TravisEz13 commented Nov 15, 2017

We will run binskim during the official build which will tell us.
https://github.com/Microsoft/binskim

@daxian-dbw
Copy link
Member

daxian-dbw commented Nov 15, 2017 •
edited
Loading

We don't build pwsh.exe, so is the executable also has this option set on?
According to https://msdn.microsoft.com/en-us/library/jj835761.aspx, if not, powershell may not be able to benefit from this option.

This is not a blocking comment.

@iSazonov
Copy link
Collaborator

iSazonov commented Nov 15, 2017

I see the option in CoreCLR https://github.com/dotnet/coreclr/search?utf8=%E2%9C%93&q=HIGHENTROPYVA&type=

daxian-dbw
daxian-dbw approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit:

@daxian-dbw daxian-dbw merged commit 5d8999e into PowerShell:master Nov 15, 2017
@TravisEz13 TravisEz13 deleted the add_HighEntropyVA branch November 15, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

@iSazonov iSazonov iSazonov approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

Assignees

@adityapatwardhan adityapatwardhan

Labels

Compliance Related to compliance requirements

Projects

None yet

Milestone

6.0.0-RC

Development

Successfully merging this pull request may close these issues.

5 participants

@TravisEz13 @daxian-dbw @iSazonov @SteveL-MSFT @adityapatwardhan