Remove 'oldPowershellExeName' contains powershell.exe #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunqingchen
requested review from
BrucePay,
daxian-dbw and
lzybkr
as code owners
chunqingchen
force-pushed
the
bugfix_1
branch
from
46cb666 to
4fc55d1
Compare
Contributor
Author
|
@daxian-dbw hi dongbo, could you please take a look? |
daxian-dbw
previously requested changes
Nov 30, 2017
Member
There was a problem hiding this comment.
old deps file should be removed.
daxian-dbw
dismissed
their stale review
New commit has been pushed to address the comment.
daxian-dbw
approved these changes
Dec 6, 2017
daxian-dbw
requested review from
adityapatwardhan
and removed request for
BrucePay
Member
|
@adityapatwardhan Can you please take a look at this PR? Thanks! |
adityapatwardhan
approved these changes
Dec 6, 2017
TravisEz13
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
Dec 7, 2017
TravisEz13
pushed a commit
that referenced
this pull request
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve #5135