Skip to content

Try fixing the 'brew update' issue in bootstrap script #5400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityapatwardhan merged 3 commits into from
Nov 13, 2017
Merged

Try fixing the 'brew update' issue in bootstrap script #5400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0bc37c
Try fixing the 'brew update' issue in bootstrap script
daxian-dbw Nov 9, 2017
cceb236
Add a log message
daxian-dbw Nov 9, 2017
bd67554
Add a comment
daxian-dbw Nov 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions tools/installpsh-osx.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,10 +127,23 @@ fi

# Suppress output, it's very noisy on travis-ci
echo "Refreshing Homebrew cache..."
if ! brew update > /dev/null; then
echo "ERROR: Refreshing Homebrew cache failed..." >&2
exit 2
fi
for count in {1..2}; do
# Try the update twice if the first time fails
brew update > /dev/null && break

# If the update fails again after increasing the Git buffer size, exit with error.
Copy link
Member

@TravisEz13 TravisEz13 Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caching the brew cache in travis-ci might help:

cache:
  directories:
    - $HOME/Library/Caches/Homebrew

Copy link
Member Author

@daxian-dbw daxian-dbw Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Travis! I will add this.

if [[ $count == 2 ]]; then
echo "ERROR: Refreshing Homebrew cache failed..." >&2
exit 2
fi

# The update failed for the first try. An error we see a lot in our CI is "RPC failed; curl 56 SSLRead() return error -36".
# What 'brew update' does is to fetch the newest version of Homebrew from GitHub using git, and the error comes from git.
# A potential solution is to increase the Git buffer size to a larger number, say 150 mb. The default buffer size is 1 mb.
echo "First attempt of update failed. Increase Git buffer size and try again ..."
git config --global http.postBuffer 157286400
sleep 5
done

# Suppress output, it's very noisy on travis-ci
if [[ ! -d $(brew --prefix cask) ]]; then
Expand Down