Try fixing the 'brew update' issue in bootstrap script #5400
Conversation
daxian-dbw
requested review from
TravisEz13 and
adityapatwardhan
as code owners
| # A potential solution is to increase the Git buffer size to a larger number, say 150 mb. The default buffer size is 1 mb. | ||
| echo "First attempt of update failed. Increase Git buffer size and try again ..." | ||
| git config --global http.postBuffer 157286400 | ||
| sleep 5 |
There was a problem hiding this comment.
Why is this required? Can you put a comment.
There was a problem hiding this comment.
Sure, will add a comment.
| # Try the update twice if the first time fails | ||
| brew update > /dev/null && break | ||
|
|
||
| # If the update fails again after increasing the Git buffer size, exit with error. |
There was a problem hiding this comment.
caching the brew cache in travis-ci might help:
cache:
directories:
- $HOME/Library/Caches/Homebrew
There was a problem hiding this comment.
Thanks Travis! I will add this.
|
@daxian-dbw Can you rebase and get #5249 |
|
@adityapatwardhan Sorry that I don't understand your comment -- the PR #5249 has been merged for over 2 weeks. |
|
Travis-CI finally passed: https://travis-ci.org/PowerShell/PowerShell/builds/300376520?utm_source=github_status&utm_medium=notification I will not add code that caches the brew cache yet (Travis suggested that) because I want to verify if the fix can resolve the "Curl error" in |
|
It seems the fix in #5429 does not fix all the webhook issues. The tests seems to have passed but GitHub doesnot seem it as passed. I will merge. |
|
@adityapatwardhan The webhook fix in that PR is for the build report in our Team channel, not for the Github package. This should be something wrong with the Travis CI. |
3 participants
This is an attempt to fix the 'brew update' failure that happens a lot in your macOS CI runs:
RPC failed; curl 56 SSLRead() return error -36.With this change, we will try run
brew updatetwice. The first run is the same as before, but if it fails, then we increase the Git buffer size before the second attempt.