Skip to content

Conversation

@dantraMSFT
Copy link
Contributor

@dantraMSFT dantraMSFT commented Nov 8, 2017

[Feature]
Fix #5378
EventResource.resx does not have a generated C# class.

@daxian-dbw
Copy link
Member

@dantraMSFT the [Feature] needs to be put in the commit message, not in the PR description.

@SteveL-MSFT
Copy link
Member

@dantraMSFT on this branch, just do a git commit --amended and update the commit message so that the first line is [Feature], then git push --force

@daxian-dbw
Copy link
Member

Something is wrong with the macOS CI. The log shows the build passed, however the CI itself is shown as broken: https://travis-ci.org/PowerShell/PowerShell/jobs/299363616

I will merge this PR.

@daxian-dbw daxian-dbw merged commit 7a78fec into PowerShell:master Nov 9, 2017
@dantraMSFT dantraMSFT deleted the dantra/issue5378 branch November 9, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants