Update 'installpsh-suse.sh' and remove 'download.sh' #5309
Conversation
daxian-dbw
requested review from
HemantMahawar,
SteveL-MSFT and
joeyaiello
as code owners
tools/installpsh-suse.sh
Outdated
| grep -q "^${pwshlink}$" /etc/shells || echo $pwshlink | $SUDO tee --append /etc/shells > /dev/null ; | ||
| fi | ||
|
|
||
| ## Remove the package |
There was a problem hiding this comment.
Maybe better to change this comment to "Remove the downloaded package file"
tools/installpsh-suse.sh
Outdated
| rm -f $package | ||
|
|
||
| powershell -noprofile -c '"Congratulations! PowerShell is installed at $PSHOME"' | ||
| pwsh -noprofile -c '"Congratulations! PowerShell is installed at $PSHOME"' |
There was a problem hiding this comment.
Maybe a good idea to indicate the new short 'pwsh' name in the message; for example "$PSHOME/pwsh" instead of "$PSHOME" - this way complete command line for launch can be copy pasted.
There was a problem hiding this comment.
pwsh will be in PATH, so you don't need the complete command. But we should indicate that run pwsh to start a powershell session.
|
There could be a lot of user automation depending on download.sh - so I think it would be better to redirect download.sh to install-powershell.sh. Or at a minimum have it emit a depreciation message. |
|
I think a redirect to |
|
@DarwinJS Thanks for bringing this up. I did a quick search of |
|
@daxian-dbw - on my last comment I forgot to say thanks a lot - I struggled trying to fix this with regular package manager commands and had to move on to other things. My intent in building install-powershell.sh was to allow the super easy installation of powershell core to add jet fuel to adoption. This includes:
FYI: I didn't even learn it was used to install for CI testing until much later. I was also thinking that there was probably many who took a direct dependency on download.sh to get rid of all the hassles of figuring out their platform specific install procedure and then keeping up to date. Although I don't think this project should feel a contractual obligation to not break that, I also feel that managing it with the sensitivity that people probably do take a dependency on it helps fuel adoption. So rather than retire it because it seems redundant, I would advise changing its contents to: |
|
@DarwinJS I chatted with @TravisEz13 offline and we agree to bring back |
|
Awesome :) |
5 participants
Fix #5023
Update
installpsh-suse.shto work with the.tar.gzbinary archive.Remove
download.shas it's not used anywhere now. (checked with PowerShellGet and OneGet, they are using a local copy ofdownload.sh).