Update powershell to use 2.0.4-servicing dotnet core runtime #5295
Conversation
|
|
||
| $dotnetCLIChannel = "release" | ||
| $dotnetCLIRequiredVersion = "2.0.0" | ||
| $dotnetCLIRequiredVersion = "2.0.2" |
There was a problem hiding this comment.
@daxian-dbw While you are at it... maybe it is a good idea to change the required version check from "exact match" to "only major+minor version should match" in build.psm1:414 . See #5260 or more details.
There was a problem hiding this comment.
|
|
||
| <TargetFramework>netcoreapp2.0</TargetFramework> | ||
| <RuntimeFrameworkVersion>2.0.0</RuntimeFrameworkVersion> | ||
| <RuntimeFrameworkVersion>2.0.4-servicing-25831-01</RuntimeFrameworkVersion> |
There was a problem hiding this comment.
The package that was tested was "25824-03".
This one, in this change, is just newer?
There was a problem hiding this comment.
Yes, it's a week newer. Produced on 10/31
There was a problem hiding this comment.
I see 2.0.4 here and 2.0.2 in Build.psm1 and global.json - could you please clarify the difference?
There was a problem hiding this comment.
The 2.0.2 in global.json and build.psm1 indicates the version of the .NET Core SDK, see global.json reference. The 2.0.4-servicing here is the version of dotnet core runtime the build will target.
dotnet --info shows 2 versions: .NET Command Line Tools version and the default .NET Core framework version. Currently the 2.0.2 .NET Core SDK still targets .NET Core runtime 2.0.0 by default.
.NET Command Line Tools (2.0.2)
Product Information:
Version: 2.0.2
Commit SHA-1 hash: a04b4bf512
...
Microsoft .NET Core Shared Framework Host
Version : 2.0.0
Build : e8b8861ac7faf042c87a5c2f9f2d04c98b69f28d
4 participants
Use
Microsoft.NETCore.App 2.0.4-servicing-25831-01to build powershell.Also update to dotnet core SDK 2.0.2.
The CoreCLR issue https://github.com/dotnet/coreclr/issues/9745 is fixed in the 2.0.4-servicing packages.
PowerShell will use .NET Core 2.0.4 servicing for the GA build, so we move to the 2.0.4 preview bits to validate dotnet core packages early.
Fix #5157