Remove DCOM support from *-Computer cmdlets (replacement for 5152) #5277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesWTruher
added
Breaking-Change
JamesWTruher
requested review from
SteveL-MSFT,
adityapatwardhan,
daxian-dbw and
iSazonov
JamesWTruher
requested review from
BrucePay,
TravisEz13 and
lzybkr
as code owners
iSazonov
approved these changes
Oct 31, 2017
Collaborator
iSazonov
left a comment
iSazonov
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
Collaborator
There was a problem hiding this comment.
Please remove extra line.
Collaborator
There was a problem hiding this comment.
Please remove extra line.
Collaborator
There was a problem hiding this comment.
Please remove extra line.
Collaborator
There was a problem hiding this comment.
Please remove extra line.
Since DCOM is not supported in corefx there was a great deal of dead code in the computer cmdlets. This PR removes all vestiges of DCOM support from: - Rename-Computer - Restart-Computer - Stop-Computer removing about 4500 lines of dead code. Also, tests are updated to provide more complete coverage. I also removed test-connection completely to make way for @iSazonov upcoming PR to improve coverage in tests, I created some test hook code which will test the cmdlet code without actually calling the WMI method to restart/rename/stop the system
JamesWTruher
force-pushed
the
jameswtruher/computertests002
branch
from
1a23aa5 to
4665dd6
Compare
5 tasks
joeyaiello
removed
Documentation Needed in this repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DCOM is not supported in corefx there was a great deal of dead code in the computer cmdlets.
This PR removes all vestiges of DCOM support from:
removing about 4500 lines of dead code. Also, tests are updated to provide more complete coverage.
I also removed test-connection completely to make way for @iSazonov upcoming PR to improve coverage in tests, I created some test hook code which will test the cmdlet code without actually calling the WMI method to restart/rename/stop the system.
this is a replacement for PR 515