Revert "Add macos launcher. (#5138)" #5259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 01fe7c2.
adityapatwardhan
requested review from
TravisEz13 and
daxian-dbw
as code owners
Member
|
This is a temporary workaround? Can you file an issue to investigate an restore this code? |
Member
Author
|
@TravisEz13 yes, filed issue to remove workaround |
TravisEz13
approved these changes
Oct 27, 2017
Member
Author
|
@TravisEz13 @daxian-dbw is this ok to merge? |
daxian-dbw
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 01fe7c2 to workaround macOS packaging issue.