Porting random hang fixes #5258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantraMSFT
approved these changes
Oct 30, 2017
Member
|
@PaulHigin Is it possible to add tests for this? |
Contributor
Author
|
@adityapatwardhan No, not safely. The code closes all opened runspaces when an "interactive host" runspaces closes, which unfortunately includes Pester runspaces. |
Contributor
Author
|
@adityapatwardhan Whoops, I though this was referring to the recent PowerShell hang on exit issue. But again, the answer is not to tests since this is fixing rare random hangs. I might be able to add test hooks, but I don't know if it is worth it. |
Member
|
We should just take this PR into account when we develop reliability specific tests as part of #4008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two fixes for random hangs found internally.
The first fix (job.cs) is for data stream Close calls on PSDataCollection objects because the method also raises public events. If an exception is thrown on the event handler then the thread never completes job clean up causing a hang. Fix is to catch all thrown exceptions and report.
The second (invokecommandcommand.cs) fixes a hang scenario where a remote job goes into disconnected state while simultaneously handling an exception. Fix is to use try/finally pattern to ensure Invoke-Command can always complete with jobs in the disconnected state.