Make sure web hook gets called #5249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisEz13
requested review from
adityapatwardhan and
daxian-dbw
as code owners
daxian-dbw
requested changes
Oct 26, 2017
Member
daxian-dbw
left a comment
daxian-dbw
left a comment
There was a problem hiding this comment.
I like this arrangement. It's cleaner. I left one comment.
tools/travis.ps1
Outdated
| $result = 'FAIL' | ||
| } | ||
|
|
||
| if ((-not $isPr) -and $cronBuild) { |
Member
There was a problem hiding this comment.
Is -not $isPr necessary? $cronBuild is true only if $env:TRAVIS_EVENT_TYPE -eq 'cron'.
adityapatwardhan
approved these changes
Oct 26, 2017
Member
adityapatwardhan
left a comment
adityapatwardhan
left a comment
There was a problem hiding this comment.
LGTM other than Dongbo's comment
daxian-dbw
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if something goes wrong during the build, we might exit and not update the badge or fire the webhook.
Enable the
after_successandafter_failurestages of the travis-ci build so we can have a better chance of getting these done.