Skip to content

import-module incorrectly reporting a loaded module was not found #5238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daxian-dbw merged 2 commits into from
Oct 26, 2017
Merged

import-module incorrectly reporting a loaded module was not found #5238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f45491c
import-module incorrectly reporting a loaded module was not found
SteveL-MSFT Oct 25, 2017
daa1ce3
[feature]
SteveL-MSFT Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,12 @@ internal bool LoadUsingModulePath(PSModuleInfo parentModule, bool found, IEnumer

module = LoadUsingExtensions(parentModule, name, qualifiedPath, extension, null, this.BasePrefix, ss, options, manifestProcessingFlags, out found);
}
if (found)
{
break;
}
#if UNIX
}
if (found)
{
break;
}
}
if (found)
{
Expand Down
19 changes: 18 additions & 1 deletion test/powershell/Modules/Microsoft.PowerShell.Core/Import-Module.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
Describe "Import-Module" -Tags "CI" {
$moduleName = "Microsoft.PowerShell.Security"
BeforeAll {
$originalPSModulePath = $env:PSModulePath
New-Item -ItemType Directory -Path "$testdrive\Modules\TestModule\1.1" -Force > $null
New-Item -ItemType Directory -Path "$testdrive\Modules\TestModule\2.0" -Force > $null
$env:PSModulePath += [System.IO.Path]::PathSeparator + "$testdrive\Modules"
New-ModuleManifest -Path "$testdrive\Modules\TestModule\1.1\TestModule.psd1" -ModuleVersion 1.1
New-ModuleManifest -Path "$testdrive\Modules\TestModule\2.0\TestModule.psd1" -ModuleVersion 2.0
}

AfterAll {
$env:PSModulePath = $originalPSModulePath
}

BeforeEach {
Remove-Module -Name $moduleName -Force
Expand All @@ -24,9 +36,14 @@

It "should be able to load an already loaded module" {
Import-Module $moduleName
{ $script:module = Import-Module $moduleName -PassThru } | Should Not Throw
{ $script:module = Import-Module $moduleName -PassThru -ErrorAction Stop } | Should Not Throw
Get-Module -Name $moduleName | Should Be $script:module
}

It "should only load the specified version" {
Import-Module TestModule -RequiredVersion 1.1
(Get-Module TestModule).Version | Should Be "1.1"
}
}

Describe "Import-Module with ScriptsToProcess" -Tags "CI" {
Expand Down